database.ForEachRow: Make sure to release semaphore

yhabteab · oxzi · commit 6a29e599a224 · 2025-04-29T15:03:34.000+02:00
Imported from Icinga/icinga-notifications@d3f7eae
diff --git a/database/utils.go b/database/utils.go
@@ -75,6 +75,7 @@ func ForEachRow[Row, Id any](ctx context.Context, db *DB, idColumn string, ids [
 	if err := sem.Acquire(ctx, 1); err != nil {
 		return errors.Wrapf(err, "cannot acquire semaphore for table %q", table)
 	}
+	defer sem.Release(1)
 
 	query := fmt.Sprintf("%s WHERE %q IN (?)", db.BuildSelectStmt(subject, subject), idColumn)
 	stmt, args, err := sqlx.In(query, ids)

Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,7 @@ func ForEachRow[Row, Id any](ctx context.Context, db *DB, idColumn string, ids [`
`75`	`75`	`if err := sem.Acquire(ctx, 1); err != nil {`
`76`	`76`	`return errors.Wrapf(err, "cannot acquire semaphore for table %q", table)`
`77`	`77`	`}`
	`78`	`+ defer sem.Release(1)`
`78`	`79`
`79`	`80`	`query := fmt.Sprintf("%s WHERE %q IN (?)", db.BuildSelectStmt(subject, subject), idColumn)`
`80`	`81`	`stmt, args, err := sqlx.In(query, ids)`