Fix compiler warnings by not unnecessarily (copy-)constructing loop variables

Author: Al2Klimov

lib/base/dependencygraph.cpp

@@ -40,8 +40,8 @@ std::vector<Object::Ptr> DependencyGraph::GetParents(const Object::Ptr& child)
 	auto it = m_Dependencies.find(child.get());
 
 	if (it != m_Dependencies.end()) {
-		typedef std::pair<Object *, int> kv_pair;
-		for (const kv_pair& kv : it->second) {
+		typedef std::pair<Object *const, int> kv_pair;
+		for (kv_pair& kv : it->second) {
 			objects.emplace_back(kv.first);
 		}
 	}

lib/base/process.cpp

@@ -632,8 +632,8 @@ void Process::IOThreadProc(int tid)
 #endif /* _WIN32 */
 
 			int i = 1;
-			typedef std::pair<ProcessHandle, Process::Ptr> kv_pair;
-			for (const kv_pair& kv : l_Processes[tid]) {
+			typedef std::pair<const ProcessHandle, Process::Ptr> kv_pair;
+			for (kv_pair& kv : l_Processes[tid]) {
 				const Process::Ptr& process = kv.second;
 #ifdef _WIN32
 				handles[i] = kv.first;

lib/remote/apilistener-configsync.cpp

@@ -125,7 +125,7 @@ Value ApiListener::ConfigUpdateObjectAPIHandler(const MessageOrigin::Ptr& origin
 				<< "Could not create object '" << objName << "':";
 
 			ObjectLock olock(errors);
-			for (const String& error : errors) {
+			for (auto& error : errors) {
 				Log(LogCritical, "ApiListener", error);
 			}
 
@@ -287,7 +287,7 @@ Value ApiListener::ConfigDeleteObjectAPIHandler(const MessageOrigin::Ptr& origin
 		Log(LogCritical, "ApiListener", "Could not delete object:");
 
 		ObjectLock olock(errors);
-		for (const String& error : errors) {
+		for (auto& error : errors) {
 			Log(LogCritical, "ApiListener", error);
 		}
 	}

lib/remote/consolehandler.cpp

@@ -31,9 +31,9 @@ static void ScriptFrameCleanupHandler()
 
 	std::vector<String> cleanup_keys;
 
-	typedef std::pair<String, ApiScriptFrame> KVPair;
+	typedef std::pair<const String, ApiScriptFrame> KVPair;
 
-	for (const KVPair& kv : l_ApiScriptFrames) {
+	for (KVPair& kv : l_ApiScriptFrames) {
 		if (kv.second.Seen < Utility::GetTime() - 1800)
 			cleanup_keys.push_back(kv.first);
 	}

lib/remote/eventqueue.cpp

@@ -116,8 +116,8 @@ std::vector<EventQueue::Ptr> EventQueue::GetQueuesForType(const String& type)
 
 	std::vector<EventQueue::Ptr> availQueues;
 
-	typedef std::pair<String, EventQueue::Ptr> kv_pair;
-	for (const kv_pair& kv : queues) {
+	typedef std::pair<const String, EventQueue::Ptr> kv_pair;
+	for (kv_pair& kv : queues) {
 		if (kv.second->CanProcessEvent(type))
 			availQueues.push_back(kv.second);
 	}

tools/mkclass/classcompiler.cpp

@@ -905,7 +905,7 @@ void ClassCompiler::HandleClass(const Klass& klass, const ClassDebugInfo&)
 				if (field.Type.ArrayRank > 0) {
 					m_Impl << "\t" << "if (oldValue) {" << std::endl
 						<< "\t\t" << "ObjectLock olock(oldValue);" << std::endl
-						<< "\t\t" << "for (const String& ref : oldValue) {" << std::endl
+						<< "\t\t" << "for (auto& ref : oldValue) {" << std::endl
 						<< "\t\t\t" << "DependencyGraph::RemoveDependency(this, ConfigObject::GetObject";
 
 					/* Ew */
@@ -919,7 +919,7 @@ void ClassCompiler::HandleClass(const Klass& klass, const ClassDebugInfo&)
 						<< "\t" << "}" << std::endl
 						<< "\t" << "if (newValue) {" << std::endl
 						<< "\t\t" << "ObjectLock olock(newValue);" << std::endl
-						<< "\t\t" << "for (const String& ref : newValue) {" << std::endl
+						<< "\t\t" << "for (auto& ref : newValue) {" << std::endl
 						<< "\t\t\t" << "DependencyGraph::AddDependency(this, ConfigObject::GetObject";
 
 					/* Ew */