Fix compiler warnings

Author: Al2Klimov

icinga-app/icinga.cpp

@@ -557,7 +557,7 @@ static int Main()
 	int rc = 1;
 
 	if (autocomplete) {
-		CLICommand::ShowCommands(argc, argv, &visibleDesc, &hiddenDesc,
+		CLICommand::ShowCommands(argc, argv, &visibleDesc,
 			&GlobalArgumentCompletion, true, autoindex);
 		rc = 0;
 	} else if (command) {

lib/base/namespace.cpp

@@ -160,6 +160,11 @@ void ConstEmbeddedNamespaceValue::Set(const Value& value, bool overrideFrozen, c
 	EmbeddedNamespaceValue::Set(value, overrideFrozen, debugInfo);
 }
 
+// A derived class instance destroyed via pointer to the base class requires the base class to provide a virtual destructor.
+NamespaceBehavior::~NamespaceBehavior()
+{
+}
+
 void NamespaceBehavior::Register(const Namespace::Ptr& ns, const String& field, const Value& value, bool, const DebugInfo&) const
 {
 	ns->SetAttribute(field, new EmbeddedNamespaceValue(value));

lib/base/namespace.hpp

@@ -45,6 +45,8 @@ class Namespace;
 
 struct NamespaceBehavior
 {
+	virtual ~NamespaceBehavior();
+
 	virtual void Register(const boost::intrusive_ptr<Namespace>& ns, const String& field, const Value& value, bool overrideFrozen, const DebugInfo& debugInfo) const;
 	virtual void Remove(const boost::intrusive_ptr<Namespace>& ns, const String& field, bool overrideFrozen);
 };

lib/base/process.cpp

@@ -211,7 +211,7 @@ static Value ProcessSpawnImpl(struct msghdr *msgh, const Dictionary::Ptr& reques
 	return response;
 }
 
-static Value ProcessKillImpl(struct msghdr *msgh, const Dictionary::Ptr& request)
+static Value ProcessKillImpl(const Dictionary::Ptr& request)
 {
 	pid_t pid = request->Get("pid");
 	int signum = request->Get("signum");
@@ -227,7 +227,7 @@ static Value ProcessKillImpl(struct msghdr *msgh, const Dictionary::Ptr& request
 	return response;
 }
 
-static Value ProcessWaitPIDImpl(struct msghdr *msgh, const Dictionary::Ptr& request)
+static Value ProcessWaitPIDImpl(const Dictionary::Ptr& request)
 {
 	pid_t pid = request->Get("pid");
 
@@ -310,9 +310,9 @@ static void ProcessHandler()
 		if (command == "spawn")
 			response = ProcessSpawnImpl(&msg, request);
 		else if (command == "waitpid")
-			response = ProcessWaitPIDImpl(&msg, request);
+			response = ProcessWaitPIDImpl(request);
 		else if (command == "kill")
-			response = ProcessKillImpl(&msg, request);
+			response = ProcessKillImpl(request);
 		else
 			response = Empty;
 

lib/base/workqueue.cpp

@@ -16,7 +16,7 @@ boost::thread_specific_ptr<WorkQueue *> l_ThreadWorkQueue;
 
 WorkQueue::WorkQueue(size_t maxItems, int threadCount, LogSeverity statsLogLevel)
 	: m_ID(m_NextID++), m_ThreadCount(threadCount), m_MaxItems(maxItems),
-	m_TaskStats(15 * 60), m_StatsLogLevel(statsLogLevel)
+	m_StatsLogLevel(statsLogLevel), m_TaskStats(15 * 60)
 {
 	/* Initialize logger. */
 	m_StatusTimerTimeout = Utility::GetTime();

lib/cli/clicommand.cpp

@@ -220,7 +220,6 @@ bool CLICommand::ParseCommand(int argc, char **argv, po::options_description& vi
 }
 
 void CLICommand::ShowCommands(int argc, char **argv, po::options_description *visibleDesc,
-	po::options_description *hiddenDesc,
 	ArgumentCompletionCallback globalArgCompletionCallback,
 	bool autocomplete, int autoindex)
 {

lib/cli/clicommand.hpp

@@ -59,7 +59,6 @@ class CLICommand : public Object
 
 	static void ShowCommands(int argc, char **argv,
 		boost::program_options::options_description *visibleDesc = nullptr,
-		boost::program_options::options_description *hiddenDesc = nullptr,
 		ArgumentCompletionCallback globalArgCompletionCallback = nullptr,
 		bool autocomplete = false, int autoindex = -1);
 

lib/cli/daemoncommand.cpp

@@ -779,8 +779,10 @@ int DaemonCommand::Run(const po::variables_map& vm, const std::vector<std::strin
 	// Whether we already forwarded a termination signal to the seamless worker
 	bool requestedTermination = false;
 
+#ifdef HAVE_SYSTEMD
 	// Whether we already notified systemd about our termination
 	bool notifiedTermination = false;
+#endif /* HAVE_SYSTEMD */
 
 	for (;;) {
 #ifdef HAVE_SYSTEMD

lib/config/expression.cpp

@@ -491,7 +491,7 @@ ExpressionResult FunctionCallExpression::DoEvaluate(ScriptFrame& frame, DebugHin
 		arguments.push_back(argres.GetValue());
 	}
 
-	return VMOps::FunctionCall(frame, self, func, arguments);
+	return VMOps::FunctionCall(self, func, arguments);
 }
 
 ExpressionResult ArrayExpression::DoEvaluate(ScriptFrame& frame, DebugHint*) const

lib/config/vmops.hpp

@@ -26,7 +26,7 @@ namespace icinga
 class VMOps
 {
 public:
-	static inline bool FindVarImportRef(ScriptFrame& frame, const std::vector<Expression::Ptr>& imports, const String& name, Value *result, const DebugInfo& debugInfo = DebugInfo())
+	static inline bool FindVarImportRef(ScriptFrame& frame, const std::vector<Expression::Ptr>& imports, const String& name, Value *result)
 	{
 		for (const auto& import : imports) {
 			ExpressionResult res = import->Evaluate(frame);
@@ -52,7 +52,7 @@ class VMOps
 		return false;
 	}
 
-	static inline Value ConstructorCall(const Type::Ptr& type, const std::vector<Value>& args, const DebugInfo& debugInfo = DebugInfo())
+	static inline Value ConstructorCall(const Type::Ptr& type, const std::vector<Value>& args)
 	{
 		if (type->GetName() == "String") {
 			if (args.empty())
@@ -81,7 +81,7 @@ class VMOps
 			return type->Instantiate(args);
 	}
 
-	static inline Value FunctionCall(ScriptFrame& frame, const Value& self, const Function::Ptr& func, const std::vector<Value>& arguments)
+	static inline Value FunctionCall(const Value& self, const Function::Ptr& func, const std::vector<Value>& arguments)
 	{
 		if (!self.IsEmpty() || self.IsString())
 			return func->InvokeThis(self, arguments);