Fix -Wunused-but-set-variable warnings (clang)

Author: jschmidt-icinga

lib/cli/clicommand.cpp

@@ -228,20 +228,16 @@ void CLICommand::ShowCommands(int argc, char **argv, po::options_description *vi
 	typedef std::map<std::vector<String>, CLICommand::Ptr>::value_type CLIKeyValue;
 
 	std::vector<String> best_match;
-	int arg_begin = 0;
 	CLICommand::Ptr command;
 
 	for (const CLIKeyValue& kv : GetRegistry()) {
 		const std::vector<String>& vname = kv.first;
 
-		arg_begin = 0;
-
 		std::vector<String>::size_type i;
 		int k;
 		for (i = 0, k = 1; i < vname.size() && k < argc; i++, k++) {
 			if (strcmp(argv[k], "--no-stack-rlimit") == 0 || strcmp(argv[k], "--autocomplete") == 0 || strcmp(argv[k], "--scm") == 0) {
 				i--;
-				arg_begin++;
 				continue;
 			}
 

lib/config/configitem.cpp

@@ -444,7 +444,9 @@ bool ConfigItem::CommitNewItems(const ActivationContext::Ptr& context, WorkQueue
 		<< "Committing " << total << " new items.";
 #endif /* I2_DEBUG */
 
+#ifdef I2_DEBUG
 	int itemsCount {0};
+#endif /* I2_DEBUG */
 
 	for (auto& type : Type::GetConfigTypesSortedByLoadDependencies()) {
 		std::atomic<int> committed_items(0);
@@ -475,9 +477,9 @@ bool ConfigItem::CommitNewItems(const ActivationContext::Ptr& context, WorkQueue
 			}
 		}
 
+#ifdef I2_DEBUG
 		itemsCount += committed_items;
 
-#ifdef I2_DEBUG
 		if (committed_items > 0)
 			Log(LogDebug, "configitem")
 				<< "Committed " << committed_items << " items of type '" << type->GetName() << "'.";

lib/remote/apilistener-filesync.cpp

@@ -104,9 +104,6 @@ void ApiListener::SyncLocalZoneDir(const Zone::Ptr& zone) const
 
 	Utility::MkDirP(productionZonesDir, 0700);
 
-	// Copy content and add additional meta data.
-	size_t numBytes = 0;
-
 	/* Note: We cannot simply copy directories here.
 	 *
 	 * Zone directories are registered from everywhere and we already
@@ -131,8 +128,6 @@ void ApiListener::SyncLocalZoneDir(const Zone::Ptr& zone) const
 
 			fp << content;
 			fp.close();
-
-			numBytes += content.GetLength();
 		}
 	}