Skip to content

Commit d3fba73

Browse files
Al2KlimovAl2Klimov
committed
Silence compiler warnings about unused parameters
Every of these parameters exists for a reason. The best we can do is to convince the compiler.
1 parent f3b1485 commit d3fba73

File tree

69 files changed

+246
-217
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

69 files changed

+246
-217
lines changed

‎lib/base/configobject.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ void ConfigObject::OnAllConfigLoaded()
421421
m_Zone = ctype->GetObject(zoneName);
422422
}
423423

424-
void ConfigObject::CreateChildObjects(const Type::Ptr& childType)
424+
void ConfigObject::CreateChildObjects(const Type::Ptr&)
425425
{
426426
/* Nothing to do here. */
427427
}

‎lib/base/configuration.cpp‎

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ String Configuration::GetApiBindHost() const
7171
return Configuration::ApiBindHost;
7272
}
7373

74-
void Configuration::SetApiBindHost(const String& val, bool suppress_events, const Value& cookie)
74+
void Configuration::SetApiBindHost(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
7575
{
7676
HandleUserWrite("ApiBindHost", &Configuration::ApiBindHost, val, m_ReadOnly);
7777
}
@@ -81,7 +81,7 @@ String Configuration::GetApiBindPort() const
8181
return Configuration::ApiBindPort;
8282
}
8383

84-
void Configuration::SetApiBindPort(const String& val, bool suppress_events, const Value& cookie)
84+
void Configuration::SetApiBindPort(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
8585
{
8686
HandleUserWrite("ApiBindPort", &Configuration::ApiBindPort, val, m_ReadOnly);
8787
}
@@ -91,7 +91,7 @@ bool Configuration::GetAttachDebugger() const
9191
return Configuration::AttachDebugger;
9292
}
9393

94-
void Configuration::SetAttachDebugger(bool val, bool suppress_events, const Value& cookie)
94+
void Configuration::SetAttachDebugger(bool val, bool /*suppress_events*/, const Value& /*cookie*/)
9595
{
9696
HandleUserWrite("AttachDebugger", &Configuration::AttachDebugger, val, m_ReadOnly);
9797
}
@@ -101,7 +101,7 @@ String Configuration::GetCacheDir() const
101101
return Configuration::CacheDir;
102102
}
103103

104-
void Configuration::SetCacheDir(const String& val, bool suppress_events, const Value& cookie)
104+
void Configuration::SetCacheDir(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
105105
{
106106
HandleUserWrite("CacheDir", &Configuration::CacheDir, val, m_ReadOnly);
107107
}
@@ -111,7 +111,7 @@ int Configuration::GetConcurrency() const
111111
return Configuration::Concurrency;
112112
}
113113

114-
void Configuration::SetConcurrency(int val, bool suppress_events, const Value& cookie)
114+
void Configuration::SetConcurrency(int val, bool /*suppress_events*/, const Value& /*cookie*/)
115115
{
116116
HandleUserWrite("Concurrency", &Configuration::Concurrency, val, m_ReadOnly);
117117
}
@@ -121,7 +121,7 @@ String Configuration::GetConfigDir() const
121121
return Configuration::ConfigDir;
122122
}
123123

124-
void Configuration::SetConfigDir(const String& val, bool suppress_events, const Value& cookie)
124+
void Configuration::SetConfigDir(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
125125
{
126126
HandleUserWrite("ConfigDir", &Configuration::ConfigDir, val, m_ReadOnly);
127127
}
@@ -131,7 +131,7 @@ String Configuration::GetDataDir() const
131131
return Configuration::DataDir;
132132
}
133133

134-
void Configuration::SetDataDir(const String& val, bool suppress_events, const Value& cookie)
134+
void Configuration::SetDataDir(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
135135
{
136136
HandleUserWrite("DataDir", &Configuration::DataDir, val, m_ReadOnly);
137137
}
@@ -141,7 +141,7 @@ String Configuration::GetEventEngine() const
141141
return Configuration::EventEngine;
142142
}
143143

144-
void Configuration::SetEventEngine(const String& val, bool suppress_events, const Value& cookie)
144+
void Configuration::SetEventEngine(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
145145
{
146146
HandleUserWrite("EventEngine", &Configuration::EventEngine, val, m_ReadOnly);
147147
}
@@ -151,7 +151,7 @@ String Configuration::GetIncludeConfDir() const
151151
return Configuration::IncludeConfDir;
152152
}
153153

154-
void Configuration::SetIncludeConfDir(const String& val, bool suppress_events, const Value& cookie)
154+
void Configuration::SetIncludeConfDir(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
155155
{
156156
HandleUserWrite("IncludeConfDir", &Configuration::IncludeConfDir, val, m_ReadOnly);
157157
}
@@ -161,7 +161,7 @@ String Configuration::GetInitRunDir() const
161161
return Configuration::InitRunDir;
162162
}
163163

164-
void Configuration::SetInitRunDir(const String& val, bool suppress_events, const Value& cookie)
164+
void Configuration::SetInitRunDir(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
165165
{
166166
HandleUserWrite("InitRunDir", &Configuration::InitRunDir, val, m_ReadOnly);
167167
}
@@ -171,7 +171,7 @@ String Configuration::GetLogDir() const
171171
return Configuration::LogDir;
172172
}
173173

174-
void Configuration::SetLogDir(const String& val, bool suppress_events, const Value& cookie)
174+
void Configuration::SetLogDir(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
175175
{
176176
HandleUserWrite("LogDir", &Configuration::LogDir, val, m_ReadOnly);
177177
}
@@ -181,7 +181,7 @@ String Configuration::GetModAttrPath() const
181181
return Configuration::ModAttrPath;
182182
}
183183

184-
void Configuration::SetModAttrPath(const String& val, bool suppress_events, const Value& cookie)
184+
void Configuration::SetModAttrPath(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
185185
{
186186
HandleUserWrite("ModAttrPath", &Configuration::ModAttrPath, val, m_ReadOnly);
187187
}
@@ -191,7 +191,7 @@ String Configuration::GetObjectsPath() const
191191
return Configuration::ObjectsPath;
192192
}
193193

194-
void Configuration::SetObjectsPath(const String& val, bool suppress_events, const Value& cookie)
194+
void Configuration::SetObjectsPath(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
195195
{
196196
HandleUserWrite("ObjectsPath", &Configuration::ObjectsPath, val, m_ReadOnly);
197197
}
@@ -201,7 +201,7 @@ String Configuration::GetPidPath() const
201201
return Configuration::PidPath;
202202
}
203203

204-
void Configuration::SetPidPath(const String& val, bool suppress_events, const Value& cookie)
204+
void Configuration::SetPidPath(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
205205
{
206206
HandleUserWrite("PidPath", &Configuration::PidPath, val, m_ReadOnly);
207207
}
@@ -211,7 +211,7 @@ String Configuration::GetPkgDataDir() const
211211
return Configuration::PkgDataDir;
212212
}
213213

214-
void Configuration::SetPkgDataDir(const String& val, bool suppress_events, const Value& cookie)
214+
void Configuration::SetPkgDataDir(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
215215
{
216216
HandleUserWrite("PkgDataDir", &Configuration::PkgDataDir, val, m_ReadOnly);
217217
}
@@ -221,7 +221,7 @@ String Configuration::GetPrefixDir() const
221221
return Configuration::PrefixDir;
222222
}
223223

224-
void Configuration::SetPrefixDir(const String& val, bool suppress_events, const Value& cookie)
224+
void Configuration::SetPrefixDir(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
225225
{
226226
HandleUserWrite("PrefixDir", &Configuration::PrefixDir, val, m_ReadOnly);
227227
}
@@ -231,7 +231,7 @@ String Configuration::GetProgramData() const
231231
return Configuration::ProgramData;
232232
}
233233

234-
void Configuration::SetProgramData(const String& val, bool suppress_events, const Value& cookie)
234+
void Configuration::SetProgramData(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
235235
{
236236
HandleUserWrite("ProgramData", &Configuration::ProgramData, val, m_ReadOnly);
237237
}
@@ -241,7 +241,7 @@ int Configuration::GetRLimitFiles() const
241241
return Configuration::RLimitFiles;
242242
}
243243

244-
void Configuration::SetRLimitFiles(int val, bool suppress_events, const Value& cookie)
244+
void Configuration::SetRLimitFiles(int val, bool /*suppress_events*/, const Value& /*cookie*/)
245245
{
246246
HandleUserWrite("RLimitFiles", &Configuration::RLimitFiles, val, m_ReadOnly);
247247
}
@@ -251,7 +251,7 @@ int Configuration::GetRLimitProcesses() const
251251
return RLimitProcesses;
252252
}
253253

254-
void Configuration::SetRLimitProcesses(int val, bool suppress_events, const Value& cookie)
254+
void Configuration::SetRLimitProcesses(int val, bool /*suppress_events*/, const Value& /*cookie*/)
255255
{
256256
HandleUserWrite("RLimitProcesses", &Configuration::RLimitProcesses, val, m_ReadOnly);
257257
}
@@ -261,7 +261,7 @@ int Configuration::GetRLimitStack() const
261261
return Configuration::RLimitStack;
262262
}
263263

264-
void Configuration::SetRLimitStack(int val, bool suppress_events, const Value& cookie)
264+
void Configuration::SetRLimitStack(int val, bool /*suppress_events*/, const Value& /*cookie*/)
265265
{
266266
HandleUserWrite("RLimitStack", &Configuration::RLimitStack, val, m_ReadOnly);
267267
}
@@ -271,7 +271,7 @@ String Configuration::GetRunAsGroup() const
271271
return Configuration::RunAsGroup;
272272
}
273273

274-
void Configuration::SetRunAsGroup(const String& val, bool suppress_events, const Value& cookie)
274+
void Configuration::SetRunAsGroup(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
275275
{
276276
HandleUserWrite("RunAsGroup", &Configuration::RunAsGroup, val, m_ReadOnly);
277277
}
@@ -281,7 +281,7 @@ String Configuration::GetRunAsUser() const
281281
return Configuration::RunAsUser;
282282
}
283283

284-
void Configuration::SetRunAsUser(const String& val, bool suppress_events, const Value& cookie)
284+
void Configuration::SetRunAsUser(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
285285
{
286286
HandleUserWrite("RunAsUser", &Configuration::RunAsUser, val, m_ReadOnly);
287287
}
@@ -291,7 +291,7 @@ String Configuration::GetSpoolDir() const
291291
return Configuration::SpoolDir;
292292
}
293293

294-
void Configuration::SetSpoolDir(const String& val, bool suppress_events, const Value& cookie)
294+
void Configuration::SetSpoolDir(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
295295
{
296296
HandleUserWrite("SpoolDir", &Configuration::SpoolDir, val, m_ReadOnly);
297297
}
@@ -301,7 +301,7 @@ String Configuration::GetStatePath() const
301301
return Configuration::StatePath;
302302
}
303303

304-
void Configuration::SetStatePath(const String& val, bool suppress_events, const Value& cookie)
304+
void Configuration::SetStatePath(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
305305
{
306306
HandleUserWrite("StatePath", &Configuration::StatePath, val, m_ReadOnly);
307307
}
@@ -311,7 +311,7 @@ double Configuration::GetTlsHandshakeTimeout() const
311311
return Configuration::TlsHandshakeTimeout;
312312
}
313313

314-
void Configuration::SetTlsHandshakeTimeout(double val, bool suppress_events, const Value& cookie)
314+
void Configuration::SetTlsHandshakeTimeout(double val, bool /*suppress_events*/, const Value& /*cookie*/)
315315
{
316316
HandleUserWrite("TlsHandshakeTimeout", &Configuration::TlsHandshakeTimeout, val, m_ReadOnly);
317317
}
@@ -321,7 +321,7 @@ String Configuration::GetVarsPath() const
321321
return Configuration::VarsPath;
322322
}
323323

324-
void Configuration::SetVarsPath(const String& val, bool suppress_events, const Value& cookie)
324+
void Configuration::SetVarsPath(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
325325
{
326326
HandleUserWrite("VarsPath", &Configuration::VarsPath, val, m_ReadOnly);
327327
}
@@ -331,7 +331,7 @@ String Configuration::GetZonesDir() const
331331
return Configuration::ZonesDir;
332332
}
333333

334-
void Configuration::SetZonesDir(const String& val, bool suppress_events, const Value& cookie)
334+
void Configuration::SetZonesDir(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
335335
{
336336
HandleUserWrite("ZonesDir", &Configuration::ZonesDir, val, m_ReadOnly);
337337
}
@@ -341,7 +341,7 @@ String Configuration::GetLocalStateDir() const
341341
return Configuration::LocalStateDir;
342342
}
343343

344-
void Configuration::SetLocalStateDir(const String& val, bool suppress_events, const Value& cookie)
344+
void Configuration::SetLocalStateDir(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
345345
{
346346
HandleUserWrite("LocalStateDir", &Configuration::LocalStateDir, val, m_ReadOnly);
347347
}
@@ -351,7 +351,7 @@ String Configuration::GetSysconfDir() const
351351
return Configuration::SysconfDir;
352352
}
353353

354-
void Configuration::SetSysconfDir(const String& val, bool suppress_events, const Value& cookie)
354+
void Configuration::SetSysconfDir(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
355355
{
356356
HandleUserWrite("SysconfDir", &Configuration::SysconfDir, val, m_ReadOnly);
357357
}
@@ -361,7 +361,7 @@ String Configuration::GetRunDir() const
361361
return Configuration::RunDir;
362362
}
363363

364-
void Configuration::SetRunDir(const String& val, bool suppress_events, const Value& cookie)
364+
void Configuration::SetRunDir(const String& val, bool /*suppress_events*/, const Value& /*cookie*/)
365365
{
366366
HandleUserWrite("RunDir", &Configuration::RunDir, val, m_ReadOnly);
367367
}

‎lib/base/filelogger.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ REGISTER_TYPE(FileLogger);
1313

1414
REGISTER_STATSFUNCTION(FileLogger, &FileLogger::StatsFunc);
1515

16-
void FileLogger::StatsFunc(const Dictionary::Ptr& status, const Array::Ptr&)
16+
void FileLogger::StatsFunc(const Dictionary::Ptr& status, const Array::Ptr& /*perfdata*/)
1717
{
1818
DictionaryData nodes;
1919

‎lib/base/io-engine.cpp‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,8 @@ IoEngine::IoEngine() : m_IoContext(), m_KeepAlive(boost::asio::make_work_guard(m
9797
IoEngine::~IoEngine()
9898
{
9999
for (auto& thread : m_Threads) {
100+
(void)thread; // Silence compiler warnings about unused variable
101+
100102
boost::asio::post(m_IoContext, []() {
101103
throw TerminateIoThread();
102104
});

‎lib/base/journaldlogger.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ REGISTER_TYPE(JournaldLogger);
1515

1616
REGISTER_STATSFUNCTION(JournaldLogger, &JournaldLogger::StatsFunc);
1717

18-
void JournaldLogger::StatsFunc(const Dictionary::Ptr& status, const Array::Ptr&)
18+
void JournaldLogger::StatsFunc(const Dictionary::Ptr& status, const Array::Ptr& /*perfdata*/)
1919
{
2020
DictionaryData nodes;
2121

‎lib/base/object.cpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ Value Object::GetFieldByName(const String& field, bool sandboxed, const DebugInf
125125
return GetField(fid);
126126
}
127127

128-
void Object::SetFieldByName(const String& field, const Value& value, bool overrideFrozen, const DebugInfo& debugInfo)
128+
void Object::SetFieldByName(const String& field, const Value& value, bool /*overrideFrozen*/, const DebugInfo& debugInfo)
129129
{
130130
Type::Ptr type = GetReflectionType();
131131

@@ -150,22 +150,22 @@ void Object::SetFieldByName(const String& field, const Value& value, bool overri
150150
}
151151
}
152152

153-
void Object::Validate(int types, const ValidationUtils& utils)
153+
void Object::Validate(int /*types*/, const ValidationUtils&)
154154
{
155155
/* Nothing to do here. */
156156
}
157157

158-
void Object::ValidateField(int id, const Lazy<Value>& lvalue, const ValidationUtils& utils)
158+
void Object::ValidateField(int /*id*/, const Lazy<Value>&, const ValidationUtils&)
159159
{
160160
/* Nothing to do here. */
161161
}
162162

163-
void Object::NotifyField(int id, const Value& cookie)
163+
void Object::NotifyField(int /*id*/, const Value& /*cookie*/)
164164
{
165165
BOOST_THROW_EXCEPTION(std::runtime_error("Invalid field ID."));
166166
}
167167

168-
Object::Ptr Object::NavigateField(int id) const
168+
Object::Ptr Object::NavigateField(int /*id*/) const
169169
{
170170
BOOST_THROW_EXCEPTION(std::runtime_error("Invalid field ID."));
171171
}

‎lib/base/scriptutils.cpp‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -502,9 +502,9 @@ void ScriptUtils::Assert(const Value& arg)
502502
BOOST_THROW_EXCEPTION(std::runtime_error("Assertion failed"));
503503
}
504504

505+
#ifdef _WIN32
505506
String ScriptUtils::MsiGetComponentPathShim(const String& component)
506507
{
507-
#ifdef _WIN32
508508
TCHAR productCode[39];
509509
if (MsiGetProductCode(component.CStr(), productCode) != ERROR_SUCCESS)
510510
return "";
@@ -513,10 +513,13 @@ String ScriptUtils::MsiGetComponentPathShim(const String& component)
513513
path[0] = '\0';
514514
MsiGetComponentPath(productCode, component.CStr(), path, &szPath);
515515
return path;
516+
}
516517
#else /* _WIN32 */
518+
String ScriptUtils::MsiGetComponentPathShim(const String& /*component*/)
519+
{
517520
return String();
518-
#endif /* _WIN32 */
519521
}
522+
#endif /* _WIN32 */
520523

521524
Array::Ptr ScriptUtils::TrackParents(const Object::Ptr& child)
522525
{

‎lib/base/sysloglogger.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ int SyslogHelper::FacilityToNumber(const String& facility)
102102
return Convert::ToLong(facility);
103103
}
104104

105-
void SyslogLogger::StatsFunc(const Dictionary::Ptr& status, const Array::Ptr&)
105+
void SyslogLogger::StatsFunc(const Dictionary::Ptr& status, const Array::Ptr& /*perfdata*/)
106106
{
107107
DictionaryData nodes;
108108

‎lib/base/type.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ int Type::GetActivationPriority() const
155155
return 0;
156156
}
157157

158-
void Type::RegisterAttributeHandler(int fieldId, const AttributeHandler& callback)
158+
void Type::RegisterAttributeHandler(int /*fieldId*/, const AttributeHandler&)
159159
{
160160
throw std::runtime_error("Invalid field ID.");
161161
}

‎lib/base/typetype-script.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ static void TypeRegisterAttributeHandler(const String& fieldName, const Function
1515
REQUIRE_NOT_NULL(self);
1616

1717
int fid = self->GetFieldId(fieldName);
18-
self->RegisterAttributeHandler(fid, [callback](const Object::Ptr& object, const Value& cookie) {
18+
self->RegisterAttributeHandler(fid, [callback](const Object::Ptr& object, const Value& /*cookie*/) {
1919
callback->Invoke({ object });
2020
});
2121
}

0 commit comments

Comments
 (0)