Checkable: Extract parents directly from dependency groups

Author: yhabteab

lib/icinga/checkable-dependency.cpp

@@ -244,12 +244,8 @@ bool Checkable::AffectsChildren() const
 std::set<Checkable::Ptr> Checkable::GetParents() const
 {
 	std::set<Checkable::Ptr> parents;
-
-	for (const Dependency::Ptr& dep : GetDependencies()) {
-		Checkable::Ptr parent = dep->GetParent();
-
-		if (parent && parent.get() != this)
-			parents.insert(parent);
+	for (auto& dependencyGroup : GetDependencyGroups()) {
+		dependencyGroup->LoadParents(parents);
 	}
 
 	return parents;

lib/icinga/dependency-group.cpp

@@ -153,6 +153,20 @@ std::vector<Dependency::Ptr> DependencyGroup::GetMembers(const Checkable* child)
 	return members;
 }
 
+/**
+ * Load all parent Checkables of the current dependency group members.
+ *
+ * @param parents The set to load the parent Checkables into.
+ */
+void DependencyGroup::LoadParents(std::set<Checkable::Ptr>& parents) const
+{
+    std::lock_guard lock(m_Mutex);
+    for (auto& [_, dependencies] : m_Members) {
+    	VERIFY(!dependencies.empty()); // We should never have an empty map for any given key at any given time.
+    	parents.insert(dependencies.begin()->second->GetParent());
+    }
+}
+
 /**
  * Retrieve the number of members in the current dependency group.
  *

lib/icinga/dependency.hpp

@@ -152,6 +152,7 @@ class DependencyGroup final : public SharedObject
 	void AddMember(const Dependency::Ptr& member);
 	void RemoveMember(const Dependency::Ptr& member);
 	std::vector<Dependency::Ptr> GetMembers(const Checkable* child) const;
+	void LoadParents(std::set<Checkable::Ptr>& parents) const;
 	size_t GetMemberCount() const;
 
 	void SetIcingaDBIdentifier(const String& identifier);