Drop user, users, usergroup and usergroups endpoints

Author: nilmerg

application/controllers/UserController.php

@@ -373,10 +373,7 @@
             ]);
         }
 
-        if (
-            ! array_key_exists('usergroups', $routeDenylist) // TODO: Remove with 1.3, compat only
-            && ! array_key_exists('contactgroups', $routeDenylist)
-        ) {
+        if (! array_key_exists('contactgroups', $routeDenylist)) {
             $overviewSection->add(N_('Contact Groups'), [
                 'description' => $this->translate('List contact groups'),
                 'url'         => 'icingadb/contactgroups',
@@ -385,10 +382,7 @@
             ]);
         }
 
-        if (
-            ! array_key_exists('users', $routeDenylist) // TODO: Remove with 1.3, compat only
-            && ! array_key_exists('contacts', $routeDenylist)
-        ) {
+        if (! array_key_exists('contacts', $routeDenylist)) {
             $overviewSection->add(N_('Contacts'), [
                 'description' => $this->translate('List contacts'),
                 'url'         => 'icingadb/contacts',
@@ -505,10 +499,7 @@
             ]);
         }
 
-        if (
-            ! array_key_exists('usergroups', $routeDenylist) // TODO: Remove with 1.3, compat only
-            && ! array_key_exists('contactgroups', $routeDenylist)
-        ) {
+        if (! array_key_exists('contactgroups', $routeDenylist)) {
             $section->add(N_('Contact Groups'), [
                 'url'           => 'icingadb/contactgroups',
                 'priority'      => 70,
@@ -517,10 +508,7 @@
             ]);
         }
 
-        if (
-            ! array_key_exists('users', $routeDenylist) // TODO: Remove with 1.3, compat only
-            && ! array_key_exists('contacts', $routeDenylist)
-        ) {
+        if (! array_key_exists('contacts', $routeDenylist)) {
             $section->add(N_('Contacts'), [
                 'url'           => 'icingadb/contacts',
                 'priority'      => 80,

application/controllers/UsergroupController.php

@@ -7,6 +7,10 @@ If you are upgrading across multiple versions, make sure to follow the steps for
 
 **Removed Features**
 
+* The routes `users`, `user`, `usergroup` and `usergroups` have been removed.
+  * Accessing these routes will result in a 404 error.
+  * The corresponding values for `icingadb/denylist/routes` have no effect anymore.
+  * The alternatives (`contacts`, `contact` , `contactgroup` and `contactgroups`) have been available since v1.2.
 * The migration widget in the top right has been removed. If you have not adjusted your navigation items,
   dashboards and bookmarks to support the new filter syntax, you will need to do so manually now (see [Upgrading to
   Icinga DB Web v1.1](#upgrading-to-icinga-db-web-v11) for details).

application/controllers/UsergroupsController.php

@@ -43,12 +43,6 @@ public function isPermittedRoute(string $name): bool
         }, $this->getAuth()->getRestrictions('icingadb/denylist/routes'))));
 
         if (! array_key_exists($name, $routeDenylist)) {
-            if ($name === 'contacts' && array_key_exists('users', $routeDenylist)) {
-                return false; // TODO: Remove with 1.3, compat only
-            } elseif ($name === 'contactgroups' && array_key_exists('usergroups', $routeDenylist)) {
-                return false; // TODO: Remove with 1.3, compat only
-            }
-
             return true;
         }