Add guard to not pass null as key to array_key_exists to ensure 8.5 compatibility

BastianLedererIcinga · BastianLedererIcinga · commit df87d2b9f965 · 2025-12-05T12:01:54.000+01:00
diff --git a/library/Icingadb/Web/Control/ViewModeSwitcher.php b/library/Icingadb/Web/Control/ViewModeSwitcher.php
@@ -104,7 +104,7 @@ public function getViewMode(): string
     {
         $viewMode = $this->getPopulatedValue($this->getViewModeParam(), $this->getDefaultViewMode());
 
-        if (array_key_exists($viewMode, static::$viewModes)) {
+        if ($viewMode && array_key_exists($viewMode, static::$viewModes)) {
             return $viewMode;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ public function getViewMode(): string`
`104`	`104`	`{`
`105`	`105`	`$viewMode = $this->getPopulatedValue($this->getViewModeParam(), $this->getDefaultViewMode());`
`106`	`106`
`107`		`- if (array_key_exists($viewMode, static::$viewModes)) {`
	`107`	`+ if ($viewMode && array_key_exists($viewMode, static::$viewModes)) {`
`108`	`108`	`return $viewMode;`
`109`	`109`	`}`
`110`	`110`