Use NotWritableError for ini config (#5404)

Replaced the unused `Zend_Config_Exception` with a more appropriate
`NotWritableError` in `IniWriter::write()`.

- The old `Zend_Config_Exception` was never caught anywhere in the
codebase.
- Changed to `NotWritableError` to better reflect file permission and
write issues.
- Added `@` suppression to the `file_put_contents()` call so that the
method can throw `NotWritableError` instead of crashing on PHP warnings.

Author: jrauh01

doc/80-Upgrading.md

@@ -12,6 +12,7 @@ v2.6 to v2.8 requires to follow the instructions for v2.7 too.
     * `service_last_time_unknown`
     * `service_last_time_warning`
     * `service_last_time_critical`
+* The `IniWriter::write()` method now throws `NotWritableError` instead of `Zend_Config_Exception`.
 
 ## Upgrading to Icinga Web 2.12.2
 

library/Icinga/File/Ini/IniWriter.php

@@ -3,14 +3,14 @@
 
 namespace Icinga\File\Ini;
 
+use Icinga\Application\Config;
 use Icinga\Application\Logger;
 use Icinga\Data\ConfigObject;
+use Icinga\Exception\NotWritableError;
 use Icinga\Exception\ProgrammingError;
 use Icinga\File\Ini\Dom\Directive;
 use Icinga\File\Ini\Dom\Document;
 use Icinga\File\Ini\Dom\Section;
-use Zend_Config_Exception;
-use Icinga\Application\Config;
 
 /**
  * A INI file adapter that respects the file structure and the comments of already existing ini files
@@ -89,22 +89,21 @@ public function render()
      * @param string $filename
      * @param bool $exclusiveLock
      *
-     * @throws Zend_Config_Exception
+     * @throws NotWritableError
      */
     public function write($filename = null, $exclusiveLock = false)
     {
         $filePath = isset($filename) ? $filename : $this->filename;
         $setMode = false === file_exists($filePath);
-
-        if (file_put_contents($filePath, $this->render(), $exclusiveLock ? LOCK_EX : 0) === false) {
-            throw new Zend_Config_Exception('Could not write to file "' . $filePath . '"');
+        if (@file_put_contents($filePath, $this->render(), $exclusiveLock ? LOCK_EX : 0) === false) {
+            throw new NotWritableError('Could not write to file "' . $filePath . '"');
         }
 
         if ($setMode) {
             // file was newly created
             $mode = $this->fileMode;
             if (is_int($this->fileMode) && false === @chmod($filePath, $this->fileMode)) {
-                throw new Zend_Config_Exception(sprintf('Failed to set file mode "%o" on file "%s"', $mode, $filePath));
+                throw new NotWritableError(sprintf('Failed to set file mode "%o" on file "%s"', $mode, $filePath));
             }
         }
     }