Change Class Default in CommonPasswordPolicy

Author: JolienTrog

.gitignore

@@ -20,3 +20,6 @@ build/*
 # Exclude dompdf font cache
 library/vendor/dompdf/lib/fonts/*.php
 library/vendor/dompdf/lib/fonts/log.htm
+
+#locale änderung für Tests sollen nicht gepushed werden
+composer.json

application/forms/Account/ChangePasswordForm.php

@@ -4,7 +4,8 @@
 namespace Icinga\Forms\Account;
 
 use Icinga\Application\Config;
-use Icinga\Application\ProvidedHook\DefaultPasswordPolicy;
+use Icinga\Application\ProvidedHook\CommonPasswordPolicy;
+use Icinga\Application\ProvidedHook\NoPasswordPolicy;
 use Icinga\Authentication\PasswordValidator;
 use Icinga\Authentication\User\DbUserBackend;
 use Icinga\Data\Filter\Filter;
@@ -40,7 +41,7 @@ public function createElements(array $formData)
         $passwordPolicy = Config::app()->get(
             'global',
             'password_policy',
-            DefaultPasswordPolicy::class
+            NoPasswordPolicy::class
         );
         $passwordPolicyObject = new $passwordPolicy();
         $passwordPolicyDescription = $passwordPolicyObject->getDescription();

application/forms/Config/General/PasswordPolicyConfigForm.php

@@ -4,7 +4,8 @@
 namespace Icinga\Forms\Config\General;
 
 use Icinga\Application\Hook;
-use Icinga\Application\ProvidedHook\DefaultPasswordPolicy;
+use Icinga\Application\ProvidedHook\CommonPasswordPolicy;
+use Icinga\Application\ProvidedHook\NoPasswordPolicy;
 use Icinga\Web\Form;
 
 /**
@@ -36,7 +37,7 @@ public function createElements(array $formData): self
                     'Enforce strong password requirements for new passwords'
                 ),
                 'label'       => $this->translate('Password Policy'),
-                'value'       => DefaultPasswordPolicy::class,
+                'value'       => NoPasswordPolicy::class,
                 'multiOptions' =>$passwordPolicies
             ]
         );

application/forms/Config/User/UserForm.php

@@ -5,7 +5,8 @@
 
 use Icinga\Application\Config;
 use Icinga\Application\Hook\ConfigFormEventsHook;
-use Icinga\Application\ProvidedHook\DefaultPasswordPolicy;
+use Icinga\Application\ProvidedHook\CommonPasswordPolicy;
+use Icinga\Application\ProvidedHook\NoPasswordPolicy;
 use Icinga\Authentication\PasswordValidator;
 use Icinga\Data\Filter\Filter;
 use Icinga\Forms\RepositoryForm;
@@ -23,7 +24,7 @@ protected function createInsertElements(array $formData)
         $passwordPolicy = Config::app()->get(
             'global',
             'password_policy',
-            DefaultPasswordPolicy::class
+            NoPasswordPolicy::class
         );
         $passwordPolicyObject = new $passwordPolicy();
         $passwordPolicyDescription = $passwordPolicyObject->getDescription();

library/Icinga/Application/ApplicationBootstrap.php

@@ -7,7 +7,7 @@
 use ErrorException;
 use Exception;
 use Icinga\Application\ProvidedHook\DbMigration;
-use Icinga\Application\ProvidedHook\DefaultPasswordPolicy;
+use Icinga\Application\ProvidedHook\CommonPasswordPolicy;
 use Icinga\Application\ProvidedHook\NoPasswordPolicy;
 use ipl\I18n\GettextTranslator;
 use ipl\I18n\StaticTranslator;
@@ -742,7 +742,7 @@ public function hasLocales()
     protected function registerApplicationHooks(): self
     {
         Hook::register('DbMigration', DbMigration::class, DbMigration::class);
-        Hook::register('passwordpolicy', DefaultPasswordPolicy::class, DefaultPasswordPolicy::class);
+        Hook::register('passwordpolicy', CommonPasswordPolicy::class, CommonPasswordPolicy::class);
         Hook::register('passwordpolicy', NoPasswordPolicy::class, NoPasswordPolicy::class);
 
         return $this;

…n/ProvidedHook/DefaultPasswordPolicy.php …on/ProvidedHook/CommonPasswordPolicy.phplibrary/Icinga/Application/ProvidedHook/DefaultPasswordPolicy.php renamed to library/Icinga/Application/ProvidedHook/CommonPasswordPolicy.php library/Icinga/Application/ProvidedHook/DefaultPasswordPolicy.php renamed to library/Icinga/Application/ProvidedHook/CommonPasswordPolicy.php

@@ -7,7 +7,7 @@
 use ipl\I18n\Translation;
 
 /**
- * Default implementation of a password policy
+ * Common implementation of a password policy
  *
  * Enforces:
  * - Minimum length of 12 characters
@@ -16,13 +16,13 @@
  * - At least one uppercase letter
  * - At least one lowercase letter
  */
-class DefaultPasswordPolicy implements PasswordPolicyHook
+class CommonPasswordPolicy implements PasswordPolicyHook
 {
     use Translation;
 
     public function getName(): string
     {
-        return $this->translate('Default');
+        return $this->translate('Common');
     }
 
     public function getDescription(): string