codereview

Author: JolienTrog

application/forms/Config/User/UserForm.php

@@ -5,6 +5,7 @@
 
 use Icinga\Application\Config;
 use Icinga\Application\Hook\ConfigFormEventsHook;
+use Icinga\Application\ProvidedHook\DefaultPasswordPolicy;
 use Icinga\Authentication\PasswordValidator;
 use Icinga\Data\Filter\Filter;
 use Icinga\Forms\RepositoryForm;
@@ -22,7 +23,8 @@ protected function createInsertElements(array $formData)
         $passwordPolicyObject = null;
         $passwordPolicy = Config::app()->get(
             'global',
-            'password_policy'
+            'password_policy',
+            DefaultPasswordPolicy::class
         );
         if (isset($passwordPolicy)) {
             $passwordPolicyObject = new $passwordPolicy();

library/Icinga/Application/ApplicationBootstrap.php

@@ -8,7 +8,7 @@
 use Exception;
 use Icinga\Application\ProvidedHook\DbMigration;
 use Icinga\Application\ProvidedHook\DefaultPasswordPolicy;
-use Icinga\Application\ProvidedHook\NonePasswordPolicy;
+use Icinga\Application\ProvidedHook\NoPasswordPolicy;
 use ipl\I18n\GettextTranslator;
 use ipl\I18n\StaticTranslator;
 use LogicException;
@@ -743,7 +743,7 @@ protected function registerApplicationHooks(): self
     {
         Hook::register('DbMigration', DbMigration::class, DbMigration::class);
         Hook::register('passwordpolicy', DefaultPasswordPolicy::class, DefaultPasswordPolicy::class);
-        Hook::register('passwordpolicy', NonePasswordPolicy::class, NonePasswordPolicy::class);
+        Hook::register('passwordpolicy', NoPasswordPolicy::class, NoPasswordPolicy::class);
 
         return $this;
     }

library/Icinga/Application/ProvidedHook/DefaultPasswordPolicy.php

@@ -28,7 +28,7 @@ public function getName(): string
     public function getDescription(): string
     {
         return $this->translate(
-            'Password requirements: minimum 12 characters,' .
+            'Password requirements: minimum 12 characters, ' .
             'at least 1 number, 1 special character, uppercase and lowercase letters.'
         );
     }

…tion/ProvidedHook/NonePasswordPolicy.php …cation/ProvidedHook/NoPasswordPolicy.phplibrary/Icinga/Application/ProvidedHook/NonePasswordPolicy.php renamed to library/Icinga/Application/ProvidedHook/NoPasswordPolicy.php library/Icinga/Application/ProvidedHook/NonePasswordPolicy.php renamed to library/Icinga/Application/ProvidedHook/NoPasswordPolicy.php

@@ -9,9 +9,10 @@
 /**
  * None Password Policy to validate all passwords
  */
-class NonePasswordPolicy implements PasswordPolicyHook
+class NoPasswordPolicy implements PasswordPolicyHook
 {
     use Translation;
+
     public function getName(): string
     {
         return $this->translate('None');