Always populate all available fields of Weekly/MonthlyFields

Don't only populate fields that have been choosen by the user, but also
that wern't selected with the unchecked value, just as a normal form
frequest does.

Author: yhabteab

src/FormElement/ScheduleElement/Common/FieldsUtils.php

@@ -85,8 +85,9 @@ public function loadRRule(RRule $rule): array
         $values = [];
         $isMonthly = $rule->getFrequency() === RRule::MONTHLY;
         if ($isMonthly && (! empty($rule->getByMonthDay()) || empty($rule->getByDay()))) {
-            foreach ($rule->getByMonthDay() ?? [] as $value) {
-                $values["day$value"] = 'y';
+            $monthDays = $rule->getByMonthDay() ?? [];
+            foreach (range(1, $this->availableFields) as $value) {
+                $values["day$value"] = in_array((string) $value, $monthDays, true) ? 'y' : 'n';
             }
 
             $values['runsOn'] = MonthlyFields::RUNS_EACH;

src/FormElement/ScheduleElement/WeeklyFields.php

@@ -78,20 +78,15 @@ public function getSelectedWeekDays(): array
     /**
      * Transform the given weekdays into key=>value array that can be populated
      *
-     * @param array $days
+     * @param array $weekdays
      *
      * @return array
      */
-    public function loadWeekDays(array $days): array
+    public function loadWeekDays(array $weekdays): array
     {
         $values = [];
-        foreach ($days as $day) {
-            $weekDays = strtoupper($day);
-            if (! isset($this->weekdays[$weekDays])) {
-                throw new InvalidArgumentException(sprintf('Invalid weekday provided: %s', $day));
-            }
-
-            $values[$weekDays] = 'y';
+        foreach ($this->weekdays as $weekday => $_) {
+            $values[$weekday] = in_array($weekday, $weekdays, true) ? 'y' : 'n';
         }
 
         return $values;