Suggestions: Do not rely on content to detect exact matches

Extending classes might adjust content beforehand and then
the first `li` won't necessarily include a `button`.

fixes #265

Author: nilmerg

src/Control/SearchBar/Suggestions.php

@@ -8,7 +8,6 @@
 use ipl\Html\BaseHtmlElement;
 use ipl\Html\FormattedString;
 use ipl\Html\FormElement\ButtonElement;
-use ipl\Html\FormElement\InputElement;
 use ipl\Html\HtmlElement;
 use ipl\Html\Text;
 use ipl\Stdlib\Contract\Paginatable;
@@ -242,11 +241,17 @@ protected function assemble()
             $data = new LimitIterator(new IteratorIterator($this->data), 0, self::DEFAULT_LIMIT);
         }
 
+        $noDefault = null;
         foreach ($data as $term => $meta) {
             if (is_int($term)) {
                 $term = $meta;
             }
 
+            if ($this->searchTerm) {
+                // Only the first exact match will set this to true, any other to false
+                $noDefault = $noDefault === null && $term === $this->searchTerm;
+            }
+
             $attributes = [
                 'type'          => 'button',
                 'tabindex'      => -1,
@@ -290,14 +295,6 @@ protected function assemble()
             $this->getAttributes()->add('class', 'has-more');
         }
 
-        $showDefault = true;
-        if ($this->searchTerm && $this->count() === 1) {
-            // The default option is only shown if the user's input does not result in an exact match
-            $input = $this->getFirst('li')->getFirst('button');
-            $showDefault = $input->getContent() != $this->searchTerm
-                && $input->getAttributes()->get('data-search')->getValue() != $this->searchTerm;
-        }
-
         if ($this->type === 'column' && ! $this->isEmpty() && ! $this->getFirst('li')->getAttributes()->has('class')) {
             // The column title is only added if there are any suggestions and the first item is not a title already
             $this->prependHtml(new HtmlElement(
@@ -307,7 +304,7 @@ protected function assemble()
             ));
         }
 
-        if ($showDefault) {
+        if (! $noDefault) {
             $this->assembleDefault();
         }