Skip to content

Commit 5cc314b

Browse files
jasonmolendaIcohedron
authored andcommitted
[lldb][NFC] Remove old skipIfOutOfTreeDebugserver's (llvm#126144)
When a test depends on a new debugserver feature/fix, the API test must be marked @skipIfOutOfTreeDebugserver because the macOS CI bots test using the latest Xcode release debugserver. But over time all of these fixes & new features are picked up in the Xcode debugserver and these skips can be removed. We may see unexpected test failures from removing all of these 1+ year old skips, but that's likely a separate reason the test is failing that is being papered over by this skip.
1 parent 991397c commit 5cc314b

File tree

20 files changed

+0
-32
lines changed

20 files changed

+0
-32
lines changed

lldb/test/API/commands/register/register/register_command/TestRegisters.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ def test_fp_register_write(self):
111111
# "register read fstat" always return 0xffff
112112
@expectedFailureAndroid(archs=["i386"])
113113
@skipIf(archs=no_match(["amd64", "i386", "x86_64"]))
114-
@skipIfOutOfTreeDebugserver
115114
@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr37995")
116115
def test_fp_special_purpose_register_read(self):
117116
"""Test commands that read fpu special purpose registers."""

lldb/test/API/commands/watchpoints/unaligned-watchpoint/TestUnalignedWatchpoint.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
class UnalignedWatchpointTestCase(TestBase):
1717
NO_DEBUG_INFO_TESTCASE = True
1818

19-
@skipIfOutOfTreeDebugserver
2019
def test_unaligned_watchpoint(self):
2120
"""Test an unaligned watchpoint triggered by a larger aligned write."""
2221
self.build()

lldb/test/API/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/TestHWBreakMultiThread.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,12 @@ class HardwareBreakpointMultiThreadTestCase(HardwareBreakpointTestBase):
1515
def does_not_support_hw_breakpoints(self):
1616
return not super().supports_hw_breakpoints()
1717

18-
@skipIfOutOfTreeDebugserver
1918
@skipTestIfFn(does_not_support_hw_breakpoints)
2019
def test_hw_break_set_delete_multi_thread_macos(self):
2120
self.build()
2221
self.setTearDownCleanup()
2322
self.break_multi_thread("delete")
2423

25-
@skipIfOutOfTreeDebugserver
2624
@skipTestIfFn(does_not_support_hw_breakpoints)
2725
def test_hw_break_set_disable_multi_thread_macos(self):
2826
self.build()

lldb/test/API/functionalities/scripted_process/TestStackCoreScriptedProcess.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ def get_module_with_name(self, target, name):
3232
return None
3333

3434
@skipUnlessDarwin
35-
@skipIfOutOfTreeDebugserver
3635
@skipIfRemote
3736
@skipIfAsan # On ASAN builds, this test times-out (rdar://98678134)
3837
@skipIfDarwin

lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentManyBreakpoints.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
class ConcurrentManyBreakpoints(ConcurrentEventsBase):
88
# Atomic sequences are not supported yet for MIPS in LLDB.
99
@skipIf(triple="^mips")
10-
@skipIfOutOfTreeDebugserver
1110
@expectedFailureAll(
1211
archs=["aarch64"], oslist=["freebsd"], bugnumber="llvm.org/pr49433"
1312
)

lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentManyCrash.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
class ConcurrentManyCrash(ConcurrentEventsBase):
88
# Atomic sequences are not supported yet for MIPS in LLDB.
99
@skipIf(triple="^mips")
10-
@skipIfOutOfTreeDebugserver
1110
def test(self):
1211
"""Test 100 threads that cause a segfault."""
1312
self.build()

lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentManySignals.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ class ConcurrentManySignals(ConcurrentEventsBase):
1010
# This test is flaky on Darwin.
1111
@skipIfDarwin
1212
@expectedFailureNetBSD
13-
@skipIfOutOfTreeDebugserver
1413
def test(self):
1514
"""Test 100 signals from 100 threads."""
1615
self.build()

lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentManyWatchpoints.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ class ConcurrentManyWatchpoints(ConcurrentEventsBase):
88
# Atomic sequences are not supported yet for MIPS in LLDB.
99
@skipIf(triple="^mips")
1010
@add_test_categories(["watchpoint"])
11-
@skipIfOutOfTreeDebugserver
1211
def test(self):
1312
"""Test 100 watchpoints from 100 threads."""
1413
self.build()

lldb/test/API/functionalities/watchpoint/large-watchpoint/TestLargeWatchpoint.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ def continue_and_report_stop_reason(self, process, iter_str):
2727

2828
# debugserver only gained the ability to watch larger regions
2929
# with this patch.
30-
@skipIfOutOfTreeDebugserver
3130
def test_large_watchpoint(self):
3231
"""Test watchpoint that covers a large region of memory."""
3332
self.build()

lldb/test/API/functionalities/watchpoint/unaligned-spanning-two-dwords/TestUnalignedSpanningDwords.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ def hit_watchpoint_and_continue(self, process, iter_str):
3232
# older debugservers will return the base address of the doubleword
3333
# which lldb doesn't understand, and will stop executing without a
3434
# proper stop reason.
35-
@skipIfOutOfTreeDebugserver
3635
def test_unaligned_watchpoint(self):
3736
"""Test a watchpoint that is handled by two hardware watchpoint registers."""
3837
self.build()

0 commit comments

Comments
 (0)