Skip to content

Commit 7f4b3ed

Browse files
committed
Support for -sonarurl -sonarlogin -sonarpassword arguments
1 parent 3c6be46 commit 7f4b3ed

File tree

2 files changed

+62
-23
lines changed

2 files changed

+62
-23
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212

1313
#### Enhancements
1414

15-
- None.
15+
- Sped up analysis with a single build test using 'build-for-testing'
16+
- run-sonar-swift.sh now supports -sonarurl -sonarlogin and -sonarpassword arguments for SonarQube server connection
1617

1718
#### Bug Fixes
1819

sonar-swift-plugin/src/main/shell/run-sonar-swift.sh

Lines changed: 60 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -150,23 +150,48 @@ lizard="on"
150150
oclint="on"
151151
fauxpas="on"
152152
sonarscanner=""
153-
154-
while [ $# -gt 0 ]
155-
do
156-
case "$1" in
157-
-v) vflag=on;;
158-
-n) nflag=on;;
159-
-nounittests) unittests="";;
160-
-noswiftlint) swiftlint="";;
161-
-notailor) tailor="";;
162-
-usesonarscanner) sonarscanner="on";;
163-
--) shift; break;;
164-
-*)
165-
echo >&2 "Usage: $0 [-v]"
166-
exit 1;;
167-
*) break;; # terminate while loop
168-
esac
169-
shift
153+
sonarurl=""
154+
sonarlogin=""
155+
sonarpassword=""
156+
157+
while [ "$1" != "" ]; do
158+
param=$(echo "$1" | awk -F= '{print $1}')
159+
value=$(echo "$1" | sed 's/^[^=]*=//g')
160+
161+
case $param in
162+
-v)
163+
vflag=on
164+
;;
165+
-n)
166+
nflag=on
167+
;;
168+
-nounittests)
169+
unittests=""
170+
;;
171+
-noswiftlint)
172+
swiftlint=""
173+
;;
174+
-notailor)
175+
tailor=""
176+
;;
177+
-usesonarscanner)
178+
sonarscanner="on"
179+
;;
180+
-sonarurl)
181+
sonarurl="$value"
182+
;;
183+
-sonarlogin)
184+
sonarlogin="$value"
185+
;;
186+
-sonarpassword)
187+
sonarpassword="$value"
188+
;;
189+
*)
190+
echo >&2 "Usage: $0 [-v] [-n] [-nounittests] [-noswiftlint)] [-notailor] [-usesonarscanner] [-sonarurl=value] [-sonarlogin=value] [-sonarpassword=value]"
191+
exit 1
192+
;;
193+
esac
194+
shift
170195
done
171196

172197
# Usage OK
@@ -331,9 +356,9 @@ if [ "$unittests" = "on" ]; then
331356
mv build/reports/junit.xml sonar-reports/TEST-report.xml
332357

333358

334-
echo '\nComputing coverage report\n'
359+
echo 'Computing coverage report'
335360

336-
firstProject=$(echo $projectFile | sed -n 1'p' | tr ',' '\n' | head -n 1)
361+
firstProject=$(echo $projectFile | sed -n 1'p' | tr ',' '\n' | head -n 1)
337362

338363
slatherCmd=($SLATHER_CMD coverage)
339364

@@ -516,22 +541,35 @@ else
516541
#if we have version number in properties file, we don't overide numVersion for sonar-runner/sonar-scanner command
517542
numVersionSonarRunner='';
518543
fi
544+
# Build sonar-runner / sonnar-scanner arguments
545+
sonarArguments=();
546+
if [ "$sonarurl" != "" ]; then
547+
sonarArguments+=(-Dsonar.host.url=$sonarurl)
548+
fi
549+
if [ "$sonarlogin" != "" ]; then
550+
sonarArguments+=(-Dsonar.login=$sonarlogin)
551+
fi
552+
if [ "$sonarpassword" != "" ]; then
553+
sonarArguments+=(-Dsonar.password=$sonarpassword)
554+
fi
555+
519556
# SonarQube
520557
if [ "$sonarscanner" = "on" ]; then
521558
echo -n 'Running SonarQube using SonarQube Scanner'
522559
if hash /dev/stdout sonar-scanner 2>/dev/null; then
523-
runCommand /dev/stdout sonar-scanner $numVersionSonarRunner
560+
runCommand /dev/stdout sonar-scanner "${sonarArguments[@]}" $numVersionSonarRunner
524561
else
525562
echo 'Skipping sonar-scanner (not installed!)'
526563
fi
527564
else
528565
echo -n 'Running SonarQube using SonarQube Runner'
529566
if hash /dev/stdout sonar-runner 2>/dev/null; then
530-
runCommand /dev/stdout sonar-runner $numVersionSonarRunner
567+
runCommand /dev/stdout sonar-runner "${sonarArguments[@]}" $numVersionSonarRunner
531568
else
532-
runCommand /dev/stdout sonar-scanner $numVersionSonarRunner
569+
runCommand /dev/stdout sonar-scanner "${sonarArguments[@]}" $numVersionSonarRunner
533570
fi
534571
fi
572+
#runCommand /dev/stdout "${slatherCmd[@]}"
535573

536574
# Kill progress indicator
537575
stopProgress

0 commit comments

Comments
 (0)