Skip to content

Remove double base64url-encoding when generating kid #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2025

Conversation

jschlyter
Copy link
Collaborator

Closes #183

@jschlyter jschlyter requested a review from a team as a code owner July 11, 2025 14:14
@jschlyter jschlyter requested a review from peppelinux July 11, 2025 14:14
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.28%. Comparing base (8cdb628) to head (2125695).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   76.28%   76.28%           
=======================================
  Files          44       44           
  Lines        4508     4508           
  Branches      850      850           
=======================================
  Hits         3439     3439           
  Misses        783      783           
  Partials      286      286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jschlyter jschlyter requested a review from rohe July 11, 2025 15:43
rohe
rohe previously approved these changes Aug 14, 2025
@jschlyter jschlyter merged commit ea9776c into IdentityPython:main Aug 17, 2025
8 checks passed
@jschlyter jschlyter deleted the kid_thumbprint branch August 17, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double Base64 Encoding of JWK Thumbprint When Assigning kid
2 participants