Skip to content

Commit 4065cfd

Browse files
committed
Make use of log format and session id derivation to replace satosa_logging
Signed-off-by: Ivan Kanakarakis <[email protected]>
1 parent 053df98 commit 4065cfd

File tree

1 file changed

+19
-12
lines changed

1 file changed

+19
-12
lines changed

src/satosa/routing.py

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,11 @@
44
import logging
55
import re
66

7-
from .context import SATOSABadContextError
8-
from .exception import SATOSAError
7+
from satosa.context import SATOSABadContextError
8+
from satosa.exception import SATOSAError
9+
10+
import satosa.logging_util as lu
11+
912

1013
logger = logging.getLogger(__name__)
1114

@@ -80,7 +83,7 @@ def backend_routing(self, context):
8083
:return: backend
8184
"""
8285
msg = "Routing to backend: {backend}".format(backend=context.target_backend)
83-
logline = "[{id}] {message}".format(id=context.state.get("SESSION_ID"), message=msg)
86+
logline = lu.LOG_FMT.format(id=lu.get_session_id(context.state), message=msg)
8487
logger.debug(logline)
8588
backend = self.backends[context.target_backend]["instance"]
8689
context.state[STATE_KEY] = context.target_frontend
@@ -99,7 +102,7 @@ def frontend_routing(self, context):
99102

100103
target_frontend = context.state[STATE_KEY]
101104
msg = "Routing to frontend: {frontend}".format(frontend=target_frontend)
102-
logline = "[{id}] {message}".format(id=context.state.get("SESSION_ID"), message=msg)
105+
logline = lu.LOG_FMT.format(id=lu.get_session_id(context.state), message=msg)
103106
logger.debug(logline)
104107
context.target_frontend = target_frontend
105108
frontend = self.frontends[context.target_frontend]["instance"]
@@ -110,10 +113,11 @@ def _find_registered_endpoint_for_module(self, module, context):
110113
match = re.search(regex, context.path)
111114
if match is not None:
112115
msg = "Found registered endpoint: module name:'{name}', endpoint: {endpoint}".format(
113-
name=module["instance"].name,
114-
endpoint=context.path)
115-
logline = "[{id}] {message}".format(
116-
id=context.state.get("SESSION_ID"), message=msg)
116+
name=module["instance"].name, endpoint=context.path
117+
)
118+
logline = lu.LOG_FMT.format(
119+
id=lu.get_session_id(context.state), message=msg
120+
)
117121
logger.debug(logline)
118122
return spec
119123

@@ -142,13 +146,14 @@ def endpoint_routing(self, context):
142146
"""
143147
if context.path is None:
144148
msg = "Context did not contain a path!"
145-
logline = "[{id}] {message}".format(
146-
id=context.state.get("SESSION_ID"), message=msg)
149+
logline = lu.LOG_FMT.format(
150+
id=lu.get_session_id(context.state), message=msg
151+
)
147152
logger.debug(logline)
148153
raise SATOSABadContextError("Context did not contain any path")
149154

150155
msg = "Routing path: {path}".format(path=context.path)
151-
logline = "[{id}] {message}".format(id=context.state.get("SESSION_ID"), message=msg)
156+
logline = lu.LOG_FMT.format(id=lu.get_session_id(context.state), message=msg)
152157
logger.debug(logline)
153158
path_split = context.path.split("/")
154159
backend = path_split[0]
@@ -157,7 +162,9 @@ def endpoint_routing(self, context):
157162
context.target_backend = backend
158163
else:
159164
msg = "Unknown backend {}".format(backend)
160-
logline = "[{id} {message}".format(id=context.state.get("SESSION_ID"), message=msg)
165+
logline = lu.LOG_FMT.format(
166+
id=lu.get_session_id(context.state), message=msg
167+
)
161168
logger.debug(logline)
162169

163170
try:

0 commit comments

Comments
 (0)