Pass over the NameID format as subject_type

Store NameID format as InternalData subject_type. This will overwrite
the defined policy. Discussion is needed as how this should be handled
exactly.

Signed-off-by: Ivan Kanakarakis <[email protected]>

Author: c00kiemon5ter

src/satosa/frontends/saml2.py

@@ -210,13 +210,13 @@ def _handle_authn_request(self, context, binding_in, idp):
 
         subject = authn_req.subject
         subject_id = subject.name_id.text if subject else None
-        # XXX TODO how should type be handled in relation to name_format above?
-        # subject_type = subject.name_id.format if subject else None
+        # XXX should subject.name_id.format overwrite name_id_policy.format?
+        subject_type = subject.name_id.format if subject else name_format
 
         requester_name = self._get_sp_display_name(idp, requester)
         internal_req = InternalData(
             subject_id=subject_id,
-            subject_type=name_format,
+            subject_type=subject_type,
             requester=requester,
             requester_name=requester_name,
         )