Introduce explicit context property to hold the query params

A POST request can have a query string. In that case context.request
will hold the data from the POST request body, and thus there is no
place to hold the query params.

With this changeset, a new property is introduced to hold the query
string, parsed as query params. The query params is a list of tuples.
Each tuple holds two elements, the query param name and the query param
value. Params with no value are dropped.

    ?param_w_value=123&param_w_no_value

Signed-off-by: Ivan Kanakarakis <[email protected]>

Author: c00kiemon5ter

src/satosa/micro_services/idp_hinting.py

@@ -41,18 +41,18 @@ def process(self, context, data):
         :param data: the internal request
         """
         target_entity_id = context.get_decoration(context.KEY_TARGET_ENTITYID)
-        query_string = context.request
+        qs_params = context.qs_params
 
-        an_issuer_is_already_selected = bool(target_entity_id)
-        query_string_is_missing = not query_string
-        if an_issuer_is_already_selected or query_string_is_missing:
+        issuer_is_already_selected = bool(target_entity_id)
+        query_string_is_missing = not qs_params
+        if issuer_is_already_selected or query_string_is_missing:
             return super().process(context, data)
 
         hints = (
             entity_id
-            for param in self.idp_hint_param_names
-            for entity_id in query_string.get(param, [])
-            if entity_id
+            for param_name in self.idp_hint_param_names
+            for qs_param_name, entity_id in qs_params
+            if param_name == qs_param_name
         )
         hint = next(hints, None)
 

src/satosa/proxy_server.py

@@ -128,6 +128,7 @@ def __call__(self, environ, start_response, debug=False):
         context.request_uri = environ.get("REQUEST_URI")
         context.request_method = environ.get("REQUEST_METHOD")
         context.http_headers = collect_http_headers(environ)
+        context.qs_params = parse_query_string(environ.get("QUERY_STRING"))
         environ['wsgi.input'].seek(0)
 
         context.cookie = environ.get("HTTP_COOKIE", "")