Skip to content

Commit b27a582

Browse files
author
Rebecka Gulliksson
committed
Remove 'enable' config param for AccountLinking.
1 parent 11edb70 commit b27a582

File tree

3 files changed

+5
-24
lines changed

3 files changed

+5
-24
lines changed
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
module: satosa.micro_services.account_linking.AccountLinking
22
name: AccountLinking
33
config:
4-
enable: Yes
54
api_url: "https://localhost:8167"
65
redirect_url: "https://localhost:8167/approve"
76
sign_key: "pki/account_linking.key"

src/satosa/micro_services/account_linking.py

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,11 @@ def __init__(self, config, *args, **kwargs):
2828
:param config: The SATOSA proxy config
2929
"""
3030
super().__init__(*args, **kwargs)
31-
self.enabled = "enable" not in config or config["enable"]
32-
if self.enabled:
33-
self.api_url = config["api_url"]
34-
self.redirect_url = config["redirect_url"]
35-
self.signing_key = RSAKey(key=rsa_load(config["sign_key"]), use="sig", alg="RS256")
36-
self.endpoint = "/handle_account_linking"
37-
logger.info("Account linking is active")
38-
else:
39-
logger.info("Account linking is not active")
31+
self.api_url = config["api_url"]
32+
self.redirect_url = config["redirect_url"]
33+
self.signing_key = RSAKey(key=rsa_load(config["sign_key"]), use="sig", alg="RS256")
34+
self.endpoint = "/handle_account_linking"
35+
logger.info("Account linking is active")
4036

4137
def _handle_al_response(self, context):
4238
"""
@@ -74,9 +70,6 @@ def process(self, context, internal_response):
7470
:return: response
7571
"""
7672

77-
if not self.enabled:
78-
return super().process(context, internal_response)
79-
8073
status_code, message = self._get_uuid(context, internal_response.auth_info.issuer, internal_response.user_id)
8174

8275
if status_code == 200:

tests/satosa/micro_services/test_account_linking.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import json
22
import re
3-
from unittest.mock import Mock
43

54
import pytest
65
import requests
@@ -36,16 +35,6 @@ def create_account_linking(self, account_linking_config):
3635
base_url="https://satosa.example.com")
3736
self.account_linking.next = lambda ctx, data: data
3837

39-
def test_disable_account_linking(self, account_linking_config):
40-
account_linking_config["enable"] = False
41-
account_linking = AccountLinking(account_linking_config, name="AccountLinking",
42-
base_url="https://satosa.example.com")
43-
mock_next_callback = Mock()
44-
account_linking.next = mock_next_callback
45-
assert account_linking.enabled is False
46-
account_linking.process(None, None)
47-
assert mock_next_callback.called
48-
4938
@responses.activate
5039
def test_existing_account_linking_with_known_known_uuid(self, account_linking_config, internal_response, context):
5140
uuid = "uuid"

0 commit comments

Comments
 (0)