Cleanup the docker start.sh script

Signed-off-by: Ivan Kanakarakis <[email protected]>

Author: c00kiemon5ter

docker/start.sh

@@ -1,46 +1,48 @@
-#!/usr/bin/env bash
+#!/usr/bin/env sh
 
-# for Click library to work in satosa-saml-metadata
-export LC_ALL=C.UTF-8
-export LANG=C.UTF-8
-
-# exit immediately on failure
 set -e
 
-if [ -z "${DATA_DIR}" ]; then
-   DATA_DIR=/opt/satosa/etc
-fi
+# for Click library to work in satosa-saml-metadata
+export LC_ALL="C.UTF-8"
+export LANG="C.UTF-8"
 
-if [ ! -d "${DATA_DIR}" ]; then
-   mkdir -p "${DATA_DIR}"
+if [ -z "${DATA_DIR}" ]
+then DATA_DIR=/opt/satosa/etc
 fi
 
-if [ -z "${PROXY_PORT}" ]; then
-   PROXY_PORT="8000"
+if [ ! -d "${DATA_DIR}" ]
+then mkdir -p "${DATA_DIR}"
 fi
 
-if [ -z "${METADATA_DIR}" ]; then
-   METADATA_DIR="${DATA_DIR}"
+if [ -z "${PROXY_PORT}" ]
+then PROXY_PORT="8000"
 fi
 
-cd ${DATA_DIR}
-
-mkdir -p ${METADATA_DIR}
+if [ -z "${METADATA_DIR}" ]
+then METADATA_DIR="${DATA_DIR}"
+fi
 
-if [ ! -d ${DATA_DIR}/attributemaps ]; then
-   cp -pr /opt/satosa/attributemaps ${DATA_DIR}/attributemaps
+if [ ! -d "${DATA_DIR}/attributemaps" ]
+then cp -pr /opt/satosa/attributemaps "${DATA_DIR}/attributemaps"
 fi
 
-# Activate virtualenv
+# activate virtualenv
 . /opt/satosa/bin/activate
 
-# generate metadata for front- (IdP) and back-end (SP) and write it to mounted volume
-
-satosa-saml-metadata proxy_conf.yaml ${DATA_DIR}/metadata.key ${DATA_DIR}/metadata.crt --dir ${METADATA_DIR}
+# generate metadata for frontend(IdP interface) and backend(SP interface)
+# write the result to mounted volume
+mkdir -p "${METADATA_DIR}"
+satosa-saml-metadata              \
+	"${DATA_DIR}/proxy_conf.yaml" \
+	"${DATA_DIR}/metadata.key"    \
+	"${DATA_DIR}/metadata.crt"    \
+	--dir "${METADATA_DIR}"
 
 # start the proxy
-if [[ -f https.key && -f https.crt ]]; then # if HTTPS cert is available, use it
-  exec gunicorn -b0.0.0.0:${PROXY_PORT} --keyfile https.key --certfile https.crt satosa.wsgi:app
-else
-  exec gunicorn -b0.0.0.0:${PROXY_PORT} satosa.wsgi:app
+# if HTTPS cert is available, use it
+https_key="${DATA_DIR}/https.key"
+https_crt="${DATA_DIR}/https.crt"
+if [ -f "$https_key" && -f "$https_crt" ]
+then exec gunicorn -b0.0.0.0:"${PROXY_PORT}" satosa.wsgi:app --keyfile "$https_key" --certfile "$https_crt"
+else exec gunicorn -b0.0.0.0:"${PROXY_PORT}" satosa.wsgi:app
 fi