Add more tests for the idp hinting micro-service

Signed-off-by: Ivan Kanakarakis <[email protected]>

Author: c00kiemon5ter

src/satosa/micro_services/idp_hinting.py

@@ -55,5 +55,6 @@ def process(self, context, data):
             if param_name == qs_param_name
         )
         hint = next(hints, None)
+
         context.decorate(context.KEY_TARGET_ENTITYID, hint)
         return super().process(context, data)

tests/satosa/micro_services/test_idp_hinting.py

@@ -3,6 +3,7 @@
 import pytest
 
 from satosa.context import Context
+from satosa.internal import InternalData
 from satosa.state import State
 from satosa.micro_services.idp_hinting import IdpHinting
 
@@ -11,6 +12,7 @@ class TestIdpHinting(TestCase):
     def setUp(self):
         context = Context()
         context.state = State()
+        internal_data = InternalData()
 
         config = {
               'allowed_params': ["idp_hinting", "idp_hint", "idphint"]
@@ -25,16 +27,31 @@ def setUp(self):
 
         self.config = config
         self.context = context
+        self.data = internal_data
         self.plugin = plugin
 
-    def test_idp_hinting(self):
-        self.context.request = {}
+    def test_no_query_params(self):
+        self.context.qs_params = {}
+        new_context, new_data = self.plugin.process(self.context, self.data)
+        assert not new_context.get_decoration(Context.KEY_TARGET_ENTITYID)
+
+    def test_hint_in_params(self):
         _target = 'https://localhost:8080'
         self.context.qs_params = {'idphint': _target}
-        res = self.plugin.process(self.context, data={})
-        assert res[0].internal_data.get('target_entity_id') == _target
+        new_context, new_data = self.plugin.process(self.context, self.data)
+        assert new_context.get_decoration(Context.KEY_TARGET_ENTITYID) == _target
+
+    def test_no_hint_in_params(self):
+        _target = 'https://localhost:8080'
+        self.context.qs_params = {'param_not_in_allowed_params': _target}
+        new_context, new_data = self.plugin.process(self.context, self.data)
+        assert not new_context.get_decoration(Context.KEY_TARGET_ENTITYID)
 
-    def test_no_idp_hinting(self):
-        self.context.request = {}
-        res = self.plugin.process(self.context, data={})
-        assert not res[0].internal_data.get('target_entity_id')
+    def test_issuer_already_set(self):
+        _pre_selected_target = 'https://local.localhost:8080'
+        self.context.decorate(Context.KEY_TARGET_ENTITYID, _pre_selected_target)
+        _target = 'https://localhost:8080'
+        self.context.qs_params = {'idphint': _target}
+        new_context, new_data = self.plugin.process(self.context, self.data)
+        assert new_context.get_decoration(Context.KEY_TARGET_ENTITYID) == _pre_selected_target
+        assert new_context.get_decoration(Context.KEY_TARGET_ENTITYID) != _target