update_user internal

Author: mhindery

djangosaml2/backends.py

@@ -176,11 +176,11 @@ def authenticate(self, request, session_info=None, attribute_mapping=None, creat
 
         # Update user with new attributes from incoming request
         if user is not None:
-            user = self.update_user(user, attributes, attribute_mapping, force_save=created)
+            user = self._update_user(user, attributes, attribute_mapping, force_save=created)
 
         return user
 
-    def update_user(self, user, attributes, attribute_mapping, force_save=False):
+    def _update_user(self, user, attributes, attribute_mapping, force_save=False):
         """ Update a user with a set of attributes and returns the updated user.
 
             By default it uses a mapping defined in the settings constant

tests/testprofiles/tests.py

@@ -55,14 +55,14 @@ def test_update_user(self):
             'cn': ('John', ),
             'sn': ('Doe', ),
             }
-        backend.update_user(user, attributes, attribute_mapping)
+        backend._update_user(user, attributes, attribute_mapping)
         self.assertEqual(user.email, '[email protected]')
         self.assertEqual(user.first_name, 'John')
         self.assertEqual(user.last_name, 'Doe')
 
         attribute_mapping['saml_age'] = ('age', )
         attributes['saml_age'] = ('22', )
-        backend.update_user(user, attributes, attribute_mapping)
+        backend._update_user(user, attributes, attribute_mapping)
         self.assertEqual(user.age, '22')
 
     def test_update_user_callable_attributes(self):
@@ -81,7 +81,7 @@ def test_update_user_callable_attributes(self):
             'cn': ('John', ),
             'sn': ('Doe', ),
             }
-        backend.update_user(user, attributes, attribute_mapping)
+        backend._update_user(user, attributes, attribute_mapping)
         self.assertEqual(user.email, '[email protected]')
         self.assertEqual(user.first_name, 'John')
         self.assertEqual(user.last_name, 'Doe')
@@ -103,7 +103,7 @@ def test_update_user_empty_attribute(self):
             'sn': (),
             }
         with self.assertLogs('djangosaml2', level='DEBUG') as logs:
-            backend.update_user(user, attributes, attribute_mapping)
+            backend._update_user(user, attributes, attribute_mapping)
         self.assertEqual(user.email, '[email protected]')
         self.assertEqual(user.first_name, 'John')
         # empty attribute list: no update