Skip to content

Commit 8d15d79

Browse files
committed
Replace deprecated assert_ with more specific assertIn
More specific assert methods often provide better error messages in case of failure. For a list of deprecated unittest methods, see: https://docs.python.org/3/library/unittest.html#deprecated-aliases
1 parent a43bd5d commit 8d15d79

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

djangosaml2/tests/__init__.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,8 @@ def test_login_one_idp(self):
143143
self.assertEqual(url.path, '/simplesaml/saml2/idp/SSOService.php')
144144

145145
params = parse_qs(url.query)
146-
self.assert_('SAMLRequest' in params)
147-
self.assert_('RelayState' in params)
146+
self.assertIn('SAMLRequest', params)
147+
self.assertIn('RelayState', params)
148148

149149
saml_request = params['SAMLRequest'][0]
150150
if PY_VERSION < (2, 7):
@@ -172,8 +172,8 @@ def test_login_one_idp(self):
172172
self.assertEqual(url.path, '/simplesaml/saml2/idp/SSOService.php')
173173

174174
params = parse_qs(url.query)
175-
self.assert_('SAMLRequest' in params)
176-
self.assert_('RelayState' in params)
175+
self.assertIn('SAMLRequest', params)
176+
self.assertIn('RelayState', params)
177177
self.assertEqual(params['RelayState'][0], next)
178178

179179
def test_login_several_idps(self):
@@ -204,8 +204,8 @@ def test_login_several_idps(self):
204204
self.assertEqual(url.path, '/simplesaml/saml2/idp/SSOService.php')
205205

206206
params = parse_qs(url.query)
207-
self.assert_('SAMLRequest' in params)
208-
self.assert_('RelayState' in params)
207+
self.assertIn('SAMLRequest', params)
208+
self.assertIn('RelayState', params)
209209

210210
saml_request = params['SAMLRequest'][0]
211211
if PY_VERSION < (2, 7):
@@ -319,7 +319,7 @@ def test_logout(self):
319319
'/simplesaml/saml2/idp/SingleLogoutService.php')
320320

321321
params = parse_qs(url.query)
322-
self.assert_('SAMLRequest' in params)
322+
self.assertIn('SAMLRequest', params)
323323

324324
saml_request = params['SAMLRequest'][0]
325325
if PY_VERSION < (2, 7):
@@ -353,7 +353,7 @@ def test_logout_service_local(self):
353353
'/simplesaml/saml2/idp/SingleLogoutService.php')
354354

355355
params = parse_qs(url.query)
356-
self.assert_('SAMLRequest' in params)
356+
self.assertIn('SAMLRequest', params)
357357

358358
saml_request = params['SAMLRequest'][0]
359359
if PY_VERSION < (2, 7):
@@ -408,7 +408,7 @@ def test_logout_service_global(self):
408408
'/simplesaml/saml2/idp/SingleLogoutService.php')
409409

410410
params = parse_qs(url.query)
411-
self.assert_('SAMLResponse' in params)
411+
self.assertIn('SAMLResponse', params)
412412

413413
saml_response = params['SAMLResponse'][0]
414414
if PY_VERSION < (2, 7):

0 commit comments

Comments
 (0)