Skip to content

Commit b30470b

Browse files
committed
fix: Samesite cookie value - fixed #266
1 parent 7890740 commit b30470b

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

djangosaml2/middleware.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import time
22

3+
from django import VERSION
34
from django.conf import settings
45
from django.contrib.sessions.backends.base import UpdateError
56
from django.contrib.sessions.middleware import SessionMiddleware
@@ -8,6 +9,9 @@
89
from django.utils.http import http_date
910

1011

12+
SAMESITE_NONE = None if (VERSION[0] < 3) else 'None'
13+
14+
1115
class SamlSessionMiddleware(SessionMiddleware):
1216
cookie_name = getattr(settings, 'SAML_SESSION_COOKIE_NAME', 'saml_session')
1317

@@ -34,7 +38,7 @@ def process_response(self, request, response):
3438
self.cookie_name,
3539
path=settings.SESSION_COOKIE_PATH,
3640
domain=settings.SESSION_COOKIE_DOMAIN,
37-
samesite=None,
41+
samesite=SAMESITE_NONE,
3842
)
3943
patch_vary_headers(response, ('Cookie',))
4044
else:
@@ -68,6 +72,6 @@ def process_response(self, request, response):
6872
path=settings.SESSION_COOKIE_PATH,
6973
secure=settings.SESSION_COOKIE_SECURE or None,
7074
httponly=settings.SESSION_COOKIE_HTTPONLY or None,
71-
samesite=None
75+
samesite=SAMESITE_NONE
7276
)
7377
return response

0 commit comments

Comments
 (0)