Skip to content

Commit 8c25f5d

Browse files
committed
salt is needed in more places than in the creation of a Fernet key.
1 parent b4c2b91 commit 8c25f5d

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

src/idpyoidc/encrypter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ def default_crypt_config():
1414
"kwargs": {
1515
"key": os.urandom(32),
1616
# "password": os.urandom(16),
17-
# "salt": os.urandom(16)
17+
"salt": os.urandom(16)
1818
# "keys": {
1919
# "key_defs": [
2020
# {"type": "OCT", "use": ["enc"], "kid": "password"},

src/idpyoidc/server/session/manager.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,6 @@ def __init__(
123123

124124
self.auth_req_id_map = {}
125125

126-
# def load_key(self):
127-
# """returns the original key assigned in init"""
128-
# return self.crypt_config["password"]
129-
#
130126
def get_salt(self):
131127
"""returns the original salt assigned in init"""
132128
return self.crypt_config["kwargs"]["salt"]

tests/test_20_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ def test_entity_config(filename):
9696
def test_init_crypto_None():
9797
_res = init_encrypter()
9898
assert _res["conf"]["class"] == DEFAULT_CRYPTO
99-
assert set(_res["conf"]["kwargs"].keys()) == {"key"}
99+
assert set(_res["conf"]["kwargs"].keys()) == {"key", "salt"}
100100
assert isinstance(_res["encrypter"], FernetEncrypter)
101101

102102

0 commit comments

Comments
 (0)