Form post response ContentType MUST be set to "text/html".

Author: rohe

src/oidcendpoint/endpoint.py

@@ -35,6 +35,22 @@
             - _parse_args
             - post_construct (*)
     - update_http_args
+    
+do_response returns a dictionary that can look like this:
+{
+  'response': 
+    _response as a string or as a Message instance_ 
+  'http_headers': [
+    ('Content-type', 'application/json'), 
+    ('Pragma', 'no-cache'), 
+    ('Cache-Control', 'no-store')
+  ],
+  'cookie': _list of cookies_
+}
+
+"response" MUST be present
+"http_headers" MAY be present
+"cookie": MAY be present 
 """
 
 
@@ -319,6 +335,9 @@ def response_info(self, response_args, request, **kwargs):
         return self.construct(response_args, request, **kwargs)
 
     def do_response(self, response_args=None, request=None, error="", **kwargs):
+        """
+
+        """
         do_placement = True
         content_type = "text/html"
         _resp = {}
@@ -336,43 +355,47 @@ def do_response(self, response_args=None, request=None, error="", **kwargs):
         elif "response_msg" in kwargs:
             resp = kwargs["response_msg"]
             do_placement = False
-            _response = ""  # This is just for my IDE
-            if self.response_format == "json":
-                content_type = "application/json"
-            elif self.request_format in ["jws", "jwe", "jose"]:
-                content_type = "application/jose"
-            else:
-                content_type = "application/x-www-form-urlencoded"
-        else:
-            _response = self.response_info(response_args, request, **kwargs)
-
-        if do_placement:
-            if self.response_placement == "body":
+            _response = ""
+            content_type = kwargs.get('content_type')
+            if content_type is None:
                 if self.response_format == "json":
                     content_type = "application/json"
-                    resp = _response.to_json()
                 elif self.request_format in ["jws", "jwe", "jose"]:
                     content_type = "application/jose"
-                    resp = _response
                 else:
                     content_type = "application/x-www-form-urlencoded"
-                    resp = _response.to_urlencoded()
-            elif self.response_placement == "url":
-                # content_type = 'application/x-www-form-urlencoded'
-                content_type = ""
-                try:
-                    fragment_enc = kwargs["fragment_enc"]
-                except KeyError:
-                    fragment_enc = fragment_encoding(kwargs["return_type"])
+        else:
+            _response = self.response_info(response_args, request, **kwargs)
 
-                if fragment_enc:
-                    resp = _response.request(kwargs["return_uri"], True)
+        if do_placement:
+            content_type = kwargs.get('content_type')
+            if content_type is None:
+                if self.response_placement == "body":
+                    if self.response_format == "json":
+                        content_type = "application/json"
+                        resp = _response.to_json()
+                    elif self.request_format in ["jws", "jwe", "jose"]:
+                        content_type = "application/jose"
+                        resp = _response
+                    else:
+                        content_type = "application/x-www-form-urlencoded"
+                        resp = _response.to_urlencoded()
+                elif self.response_placement == "url":
+                    # content_type = 'application/x-www-form-urlencoded'
+                    content_type = ""
+                    try:
+                        fragment_enc = kwargs["fragment_enc"]
+                    except KeyError:
+                        fragment_enc = fragment_encoding(kwargs["return_type"])
+
+                    if fragment_enc:
+                        resp = _response.request(kwargs["return_uri"], True)
+                    else:
+                        resp = _response.request(kwargs["return_uri"])
                 else:
-                    resp = _response.request(kwargs["return_uri"])
-            else:
-                raise ValueError(
-                    "Don't know where that is: '{}".format(self.response_placement)
-                )
+                    raise ValueError(
+                        "Don't know where that is: '{}".format(self.response_placement)
+                    )
 
         if content_type:
             try:

src/oidcendpoint/oidc/authorization.py

@@ -458,6 +458,7 @@ def response_mode(self, request, **kwargs):
                 action=kwargs["return_uri"],
             )
             kwargs["response_msg"] = msg
+            kwargs["content_type"] = 'text/html'
         elif resp_mode == "fragment":
             if "fragment_enc" in kwargs:
                 if not kwargs["fragment_enc"]:

tests/test_24_oidc_authorization_endpoint.py

@@ -723,12 +723,20 @@ def test_response_mode_form_post(self):
             "return_uri": "https://example.com/cb",
         }
         info = self.endpoint.response_mode(request, **info)
-        assert set(info.keys()) == {"response_args", "return_uri", "response_msg"}
+        assert set(info.keys()) == {"response_args", "return_uri", "response_msg", "content_type"}
         assert info["response_msg"] == FORM_POST.format(
             action="https://example.com/cb",
             inputs='<input type="hidden" name="foo" value="bar"/>',
         )
 
+    def test_do_response_code_form_post(self):
+        _req = AUTH_REQ_DICT.copy()
+        _req["response_mode"] = "form_post"
+        _pr_resp = self.endpoint.parse_request(_req)
+        _resp = self.endpoint.process_request(_pr_resp)
+        msg = self.endpoint.do_response(**_resp)
+        assert ('Content-type', 'text/html') in msg["http_headers"]
+
     def test_response_mode_fragment(self):
         request = {"response_mode": "fragment"}
         self.endpoint.response_mode(request, fragment_enc=True)