Skip to content
This repository was archived by the owner on Jun 12, 2021. It is now read-only.

Commit b0211bf

Browse files
committed
Don't use splitquery - deprecated.
1 parent 0621a30 commit b0211bf

File tree

1 file changed

+19
-7
lines changed

1 file changed

+19
-7
lines changed

src/oidcendpoint/oidc/registration.py

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,10 @@
55
import time
66
from random import random
77
from urllib.parse import parse_qs
8-
from urllib.parse import splitquery
98
from urllib.parse import urlencode
109
from urllib.parse import urlparse
10+
from urllib.parse import urlsplit
11+
from urllib.parse import urlunsplit
1112

1213
from cryptojwt.jws.utils import alg2keytype
1314
from oidcmsg.exception import MessageException
@@ -90,6 +91,21 @@ def secret(seed, sid):
9091
return csum.hexdigest()
9192

9293

94+
def split_uri(uri):
95+
p = urlsplit(uri)
96+
97+
if p.fragment:
98+
p = p._replace(fragment='')
99+
100+
if p.query:
101+
o = p._replace(query='')
102+
base = urlunsplit(o)
103+
return base, parse_qs(p.query)
104+
else:
105+
base = urlunsplit(p)
106+
return base, ''
107+
108+
93109
def comb_uri(args):
94110
for param in ["redirect_uris", "post_logout_redirect_uris"]:
95111
if param not in args:
@@ -160,11 +176,7 @@ def do_client_registration(self, request, client_id, ignore=None):
160176
"fragment",
161177
)
162178
return err
163-
base, query = splitquery(uri)
164-
if query:
165-
plruri.append((base, parse_qs(query)))
166-
else:
167-
plruri.append((base, query))
179+
plruri.append(split_uri(uri))
168180
_cinfo["post_logout_redirect_uris"] = plruri
169181

170182
if "redirect_uris" in request:
@@ -275,7 +287,7 @@ def verify_redirect_uris(registration_request):
275287
if _custom: # Can not verify a custom scheme
276288
verified_redirect_uris.append((uri, {}))
277289
else:
278-
base, query = splitquery(uri)
290+
base, query = split_uri(uri)
279291
if query:
280292
verified_redirect_uris.append((base, parse_qs(query)))
281293
else:

0 commit comments

Comments
 (0)