Apply suggestions from code review

Author: peppelinux

README.md

@@ -63,7 +63,7 @@ mdoci = MdocCborIssuer(
 mdoc = mdoci.new(
     doctype="eu.europa.ec.eudiw.pid.1",
     data=PID_DATA,
-    cert_path="app/keys/IACAmDLRoot01.der" # DS certificate 
+    # cert_path="app/keys/IACAmDLRoot01.der" # DS certificate 
 )
 
 ````
@@ -246,7 +246,7 @@ Other examples at [cbor official documentation](https://github.com/agronholm/cbo
 #### CBOR Diagnostic representation
 
 - [CBOR-DIAG-PY](https://github.com/chrysn/cbor-diag-py)
-- [Authlete's CBOR diagnostic tools](https://nextdev-api.authlete.net/api/cbor)
+- [Authlete's CBOR diagnostic tools](https://nextdev-api.authlete.net/api/cbor)
 - [Auth0 CBOR diagnostic tool](https://www.mdl.me/)
 
 #### X.509 certificates and chains

pymdoccbor/mso/issuer.py

@@ -110,7 +110,6 @@ def __init__(
 
                 if _value_cbortag:
                     v = cbor2.CBORTag(_value_cbortag, value=v)
-                    # print("\n-----\n K,V ", k, "\n", v)
 
                 if isinstance(v, dict):
                     for k2, v2 in v.items():
@@ -160,7 +159,7 @@ def sign(
         doctype: str = None,
     ) -> Sign1Message:
         """
-        Sign a mso and returns itprivate_key
+        Sign a mso and returns it
 
         :param device_key: Union[dict, None]: the device key
         :param valid_from: Union[None, datetime.datetime]: the valid from date
@@ -234,7 +233,7 @@ def sign(
             )
 
         else:
-            # print("payload diganostic notation: \n", cbor2diag(cbor2.dumps(cbor2.CBORTag(24,cbor2.dumps(payload)))))
+            logger.debug("payload diagnostic notation: {cbor2diag(cbor2.dumps(cbor2.CBORTag(24,cbor2.dumps(payload))))}")
 
             mso = Sign1Message(
                 phdr={

pymdoccbor/settings.py

@@ -36,7 +36,7 @@
 )
 
 X509_SAN_URL = os.getenv(
-    "X509_SAN_URL", "https://credential-issuer.oidc-federation.online"
+    "X509_SAN_URL", "https://credential-issuer.example.org"
 )
 
 CBORTAGS_ATTR_MAP = {

setup.py

@@ -1,18 +1,3 @@
-# Modifications have been made to the original file (available at https://github.com/IdentityPython/pyMDOC-CBOR)
-# All modifications Copyright (c) 2023 European Commission
-
-# All modifications licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-
-#     http://www.apache.org/licenses/LICENSE-2.0
-
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
 import re
 
 from glob import glob
@@ -40,13 +25,11 @@ def readme():
     classifiers=[
         "Development Status :: 4 - Beta",
         "License :: OSI Approved :: Apache Software License",
-        "Programming Language :: Python :: 3.8",
-        "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",
         "Topic :: Software Development :: Libraries :: Python Modules",
     ],
-    url="https://github.com/peppelinux/pyMDL-MDOC",
+    url="https://github.com/IdentityPython/pyMDL-MDOC",
     author="Giuseppe De Marco",
     author_email="[email protected]",
     license="License :: OSI Approved :: Apache Software License",