Skip to content

Commit 0e4f5fa

Browse files
author
Roland Hedberg
committed
Applied a modified version of a fix proposed by Valentin Gutierrez and Julian Vilas.
1 parent 0d96061 commit 0e4f5fa

File tree

2 files changed

+16
-21
lines changed

2 files changed

+16
-21
lines changed

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
'paste',
1414
'zope.interface',
1515
'repoze.who',
16-
'pycrypto >= 2.5', # 'Crypto'
16+
'pycryptodome', # 'Crypto'
1717
'pytz',
1818
'pyOpenSSL',
1919
'python-dateutil',

src/saml2/client.py

Lines changed: 15 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,6 @@
3131
from saml2.client_base import NoServiceDefined
3232
from saml2.mdstore import destinations
3333

34-
try:
35-
from urllib.parse import parse_qs
36-
except ImportError:
37-
from urlparse import parse_qs
38-
3934
import logging
4035

4136
logger = logging.getLogger(__name__)
@@ -68,17 +63,17 @@ def prepare_for_authenticate(
6863

6964
reqid, negotiated_binding, info = \
7065
self.prepare_for_negotiated_authenticate(
71-
entityid=entityid,
72-
relay_state=relay_state,
73-
binding=binding,
74-
vorg=vorg,
75-
nameid_format=nameid_format,
76-
scoping=scoping,
77-
consent=consent,
78-
extensions=extensions,
79-
sign=sign,
80-
response_binding=response_binding,
81-
**kwargs)
66+
entityid=entityid,
67+
relay_state=relay_state,
68+
binding=binding,
69+
vorg=vorg,
70+
nameid_format=nameid_format,
71+
scoping=scoping,
72+
consent=consent,
73+
extensions=extensions,
74+
sign=sign,
75+
response_binding=response_binding,
76+
**kwargs)
8277

8378
assert negotiated_binding == binding
8479

@@ -126,12 +121,12 @@ def prepare_for_negotiated_authenticate(
126121
logger.info("AuthNReq: %s", _req_str)
127122

128123
try:
129-
sigalg = kwargs["sigalg"]
124+
args = {'sigalg': kwargs["sigalg"]}
130125
except KeyError:
131-
sigalg = ""
126+
args = {}
132127

133128
http_info = self.apply_binding(binding, _req_str, destination,
134-
relay_state, sigalg=sigalg)
129+
relay_state, **args)
135130

136131
return reqid, binding, http_info
137132
else:
@@ -235,7 +230,7 @@ def do_logout(self, name_id, entity_ids, reason, expire, sign=None,
235230
if binding == BINDING_HTTP_REDIRECT:
236231
sigalg = kwargs.get(
237232
"sigalg", ds.DefaultSignature().get_sign_alg())
238-
#key = kwargs.get("key", self.signkey)
233+
# key = kwargs.get("key", self.signkey)
239234
srequest = str(request)
240235
else:
241236
srequest = self.sign(request, sign_alg=sign_alg,

0 commit comments

Comments
 (0)