Skip to content

Commit 22ec057

Browse files
committed
Correctly order response_bindings based on requested binding
Signed-off-by: Ivan Kanakarakis <[email protected]>
1 parent 1548443 commit 22ec057

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/saml2/client.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -666,12 +666,12 @@ def handle_logout_request(
666666
status = status_message_factory("Wrong user",
667667
STATUS_UNKNOWN_PRINCIPAL)
668668

669-
if binding == BINDING_SOAP:
670-
response_bindings = [BINDING_SOAP]
671-
elif binding in [BINDING_HTTP_POST, BINDING_HTTP_REDIRECT]:
672-
response_bindings = [BINDING_HTTP_POST, BINDING_HTTP_REDIRECT]
673-
else:
674-
response_bindings = self.config.preferred_binding["single_logout_service"]
669+
preferred_binding = self.config.preferred_binding.get("single_logout_service")
670+
response_bindings = {
671+
BINDING_SOAP: [BINDING_SOAP],
672+
BINDING_HTTP_POST: [BINDING_HTTP_POST, BINDING_HTTP_REDIRECT],
673+
BINDING_HTTP_REDIRECT: [BINDING_HTTP_REDIRECT, BINDING_HTTP_POST],
674+
}.get(binding, preferred_binding)
675675

676676
if sign is None:
677677
sign = self.logout_responses_signed

0 commit comments

Comments
 (0)