Skip to content

Commit 27a39d2

Browse files
johanlundbergc00kiemon5ter
authored andcommitted
Disable REFEDS Access entity categories for Swamid
Turns out the implementation of no aggregation ECs was not quite what was needed to comply with the policy for these.
1 parent 964e885 commit 27a39d2

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

src/saml2/entity_category/swamid.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -113,10 +113,12 @@
113113
ESI: MYACADEMICID_ESI,
114114
(ESI, COCOv1): MYACADEMICID_ESI + GEANT_COCO,
115115
(ESI, COCOv2): MYACADEMICID_ESI + REFEDS_COCO,
116+
# XXX: disabled temporarily until we can figure out how to handle them
117+
# these need to be able to be combined with other categories just not with each other
116118
# no aggregation categories
117-
PERSONALIZED: REFEDS_PERSONALIZED_ACCESS,
118-
PSEUDONYMOUS: REFEDS_PSEUDONYMOUS_ACCESS,
119-
ANONYMOUS: REFEDS_ANONYMOUS_ACCESS,
119+
# PERSONALIZED: REFEDS_PERSONALIZED_ACCESS,
120+
# PSEUDONYMOUS: REFEDS_PSEUDONYMOUS_ACCESS,
121+
# ANONYMOUS: REFEDS_ANONYMOUS_ACCESS,
120122
}
121123

122124
ONLY_REQUIRED = {

tests/test_37_entity_categories.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
from contextlib import closing
22

3+
import pytest
4+
35
from pathutils import full_path
46

57
from saml2 import config
@@ -291,6 +293,7 @@ def test_filter_ava_esi_coco():
291293
)
292294

293295

296+
@pytest.mark.skip("Temporarily disabled")
294297
def test_filter_ava_refeds_anonymous_access():
295298
entity_id = "https://anonymous.example.edu/saml2/metadata/"
296299
mds = MetadataStore(ATTRCONV, sec_config, disable_ssl_certificate_validation=True)
@@ -319,6 +322,7 @@ def test_filter_ava_refeds_anonymous_access():
319322
assert _eq(ava["schacHomeOrganization"], ["example.com"])
320323

321324

325+
@pytest.mark.skip("Temporarily disabled")
322326
def test_filter_ava_refeds_pseudonymous_access():
323327
entity_id = "https://pseudonymous.example.edu/saml2/metadata/"
324328
mds = MetadataStore(ATTRCONV, sec_config, disable_ssl_certificate_validation=True)
@@ -351,6 +355,7 @@ def test_filter_ava_refeds_pseudonymous_access():
351355
assert _eq(ava["schacHomeOrganization"], ["example.com"])
352356

353357

358+
@pytest.mark.skip("Temporarily disabled")
354359
def test_filter_ava_refeds_personalized_access():
355360
entity_id = "https://personalized.example.edu/saml2/metadata/"
356361
mds = MetadataStore(ATTRCONV, sec_config, disable_ssl_certificate_validation=True)

0 commit comments

Comments
 (0)