Skip to content

Commit 2b86176

Browse files
committed
Remove iteritems from dict loops for python3
Python3 has removed this and made .items() a view.
1 parent 99911f6 commit 2b86176

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

src/saml2/__init__.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ def transfer_to_element_tree(self):
173173
else:
174174
element_tree.tag = self.tag
175175

176-
for key, value in self.attributes.iteritems():
176+
for key, value in iter(self.attributes.items()):
177177
element_tree.attrib[key] = value
178178

179179
for child in self.children:
@@ -277,7 +277,7 @@ def _extension_element_from_element_tree(element_tree):
277277
namespace = None
278278
tag = elementc_tag
279279
extension = ExtensionElement(namespace=namespace, tag=tag)
280-
for key, value in element_tree.attrib.iteritems():
280+
for key, value in iter(element_tree.attrib.items()):
281281
extension.attributes[key] = value
282282
for child in element_tree:
283283
extension.children.append(_extension_element_from_element_tree(child))
@@ -302,7 +302,7 @@ def harvest_element_tree(self, tree):
302302
# Fill in the instance members from the contents of the XML tree.
303303
for child in tree:
304304
self._convert_element_tree_to_member(child)
305-
for attribute, value in tree.attrib.iteritems():
305+
for attribute, value in iter(tree.attrib.items()):
306306
self._convert_element_attribute_to_member(attribute, value)
307307
self.text = tree.text
308308

@@ -317,7 +317,7 @@ def _convert_element_attribute_to_member(self, attribute, value):
317317
def _add_members_to_element_tree(self, tree):
318318
for child in self.extension_elements:
319319
child.become_child_element_of(tree)
320-
for attribute, value in self.extension_attributes.iteritems():
320+
for attribute, value in iter(self.extension_attributes.items()):
321321
tree.attrib[attribute] = value
322322
tree.text = self.text
323323

@@ -456,7 +456,7 @@ def _get_all_c_children_with_order(self):
456456
for child in self.c_child_order:
457457
yield child
458458
else:
459-
for _, values in self.__class__.c_children.iteritems():
459+
for _, values in iter(self.__class__.c_children.items()):
460460
yield values[0]
461461

462462
def _convert_element_tree_to_member(self, child_tree):
@@ -507,7 +507,7 @@ def _add_members_to_element_tree(self, tree):
507507
member.become_child_element_of(tree)
508508
# Convert the members of this class which are XML attributes.
509509
for xml_attribute, attribute_info in \
510-
self.__class__.c_attributes.iteritems():
510+
iter(self.__class__.c_attributes.items()):
511511
(member_name, member_type, required) = attribute_info
512512
member = getattr(self, member_name)
513513
if member is not None:
@@ -902,7 +902,7 @@ def element_to_extension_element(element):
902902
exel.children.extend(element.extension_elements)
903903

904904
for xml_attribute, (member_name, typ, req) in \
905-
element.c_attributes.iteritems():
905+
iter(element.c_attributes.items()):
906906
member_value = getattr(element, member_name)
907907
if member_value is not None:
908908
exel.attributes[xml_attribute] = member_value

src/saml2/httputil.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ def extract(environ, empty=False, err=False):
165165
"""
166166
formdata = cgi.parse(environ['wsgi.input'], environ, empty, err)
167167
# Remove single entries from lists
168-
for key, value in formdata.iteritems():
168+
for key, value in iter(formdata.items()):
169169
if len(value) == 1:
170170
formdata[key] = value[0]
171171
return formdata

src/saml2/saml.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ def harvest_element_tree(self, tree):
250250
# Fill in the instance members from the contents of the XML tree.
251251
for child in tree:
252252
self._convert_element_tree_to_member(child)
253-
for attribute, value in tree.attrib.iteritems():
253+
for attribute, value in iter(tree.attrib.items()):
254254
self._convert_element_attribute_to_member(attribute, value)
255255
if tree.text:
256256
#print("set_text:", tree.text)

tools/parse_xsd2.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -865,7 +865,7 @@ def __init__(self, elem):
865865
self.scoped = False
866866
self.itemType = None
867867

868-
for attribute, value in elem.attrib.iteritems():
868+
for attribute, value in iter(elem.attrib.items()):
869869
self.__setattr__(attribute, value)
870870

871871
def collect(self, top, sup, argv=None, parent=""):
@@ -1046,7 +1046,7 @@ def __init__(self, elem):
10461046
self.scoped = False
10471047
self.abstract = False
10481048

1049-
for attribute, value in elem.attrib.iteritems():
1049+
for attribute, value in iter(elem.attrib.items()):
10501050
self.__setattr__(attribute, value)
10511051

10521052
try:

0 commit comments

Comments
 (0)