Skip to content

Commit 63b2288

Browse files
johanlundbergc00kiemon5ter
authored andcommitted
delete_one do not accept just a key as delete previous did
change delete_one to delete_many instead of iterating through results deleting all found documents
1 parent 803eb89 commit 63b2288

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

src/saml2/mongo_store.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,7 @@ def get_assertions_by_subject(self, name_id=None, session_index=None, requested_
9898
def remove_authn_statements(self, name_id):
9999
logger.debug("remove authn about: %s", name_id)
100100
key = sha1(code_binary(name_id)).hexdigest()
101-
for item in self.assertion.find({"name_id_key": key}):
102-
self.assertion.delete_one(item["_id"])
101+
self.assertion.delete_many(filter={"name_id_key": key})
103102

104103
def get_authn_statements(self, name_id, session_index=None, requested_context=None):
105104
"""
@@ -220,13 +219,11 @@ def get(self, value=None, **kwargs):
220219
def remove(self, key=None, **kwargs):
221220
if key is None:
222221
if kwargs:
223-
for item in self.db.find(kwargs):
224-
self.db.delete_one(item["_id"])
222+
self.db.delete_many(filter=kwargs)
225223
else:
226224
doc = {self.primary_key: key}
227225
doc.update(kwargs)
228-
for item in self.db.find(doc):
229-
self.db.delete_one(item["_id"])
226+
self.db.delete_many(filter=doc)
230227

231228
def keys(self):
232229
for item in self.db.find():

0 commit comments

Comments
 (0)