Merge pull request #318 from knaperek/fix-xmlsec-zombies

Wait until xmlsec program completes to avoid zombies

Author: Roland Hedberg

src/saml2/algsupport.py

@@ -39,6 +39,7 @@ def get_algorithm_support(xmlsec):
 
     p_out = pof.stdout.read().decode('utf-8')
     p_err = pof.stderr.read().decode('utf-8')
+    pof.wait()
 
     if not p_err:
         p = p_out.split('\n')
@@ -73,4 +74,4 @@ def algorithm_support_in_metadata(xmlsec):
     res = get_algorithm_support(xmlsec)
     print(res)
     for a in algorithm_support_in_metadata(xmlsec):
-        print(a)
+        print(a)

src/saml2/sigver.py

@@ -797,6 +797,7 @@ def version(self):
         com_list = [self.xmlsec, "--version"]
         pof = Popen(com_list, stderr=PIPE, stdout=PIPE)
         content = pof.stdout.read().decode('ascii')
+        pof.wait()
         try:
             return content.split(" ")[1]
         except IndexError:
@@ -990,6 +991,7 @@ def _run_xmlsec(self, com_list, extra_args, validate_output=True,
 
         p_out = pof.stdout.read().decode('utf-8')
         p_err = pof.stderr.read().decode('utf-8')
+        pof.wait()
 
         if pof.returncode is not None and pof.returncode < 0:
             logger.error(LOG_LINE, p_out, p_err)