Skip to content

Commit 711565f

Browse files
Merge pull request #585 from johanlundberg/fix_xmlsec_sign_statement
Python 3 problem with lxml.etree.tostring
2 parents fbff99e + 56f75da commit 711565f

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/saml2/sigver.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -957,7 +957,10 @@ def sign_statement(self, statement, node_name, key_file, node_id, id_attr):
957957

958958
xml = xmlsec.parse_xml(statement)
959959
signed = xmlsec.sign(xml, key_file)
960-
return lxml.etree.tostring(signed, xml_declaration=True)
960+
signed_str = lxml.etree.tostring(signed, xml_declaration=False, encoding="UTF-8")
961+
if not isinstance(signed_str, six.string_types):
962+
signed_str = signed_str.decode("utf-8")
963+
return signed_str
961964

962965
def validate_signature(self, signedtext, cert_file, cert_type, node_name, node_id, id_attr):
963966
"""

0 commit comments

Comments
 (0)