Skip to content

Commit 8db1a3b

Browse files
committed
remove unneeded method cgi_field_storage()
1 parent f501200 commit 8db1a3b

File tree

1 file changed

+1
-16
lines changed
  • src/s2repoze/plugins

1 file changed

+1
-16
lines changed

src/s2repoze/plugins/sp.py

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -58,21 +58,6 @@ def construct_came_from(environ):
5858
came_from += '?' + qstr
5959
return came_from
6060

61-
62-
def cgi_field_storage_to_dict(field_storage):
63-
"""Get a plain dictionary, rather than the '.value' system used by the
64-
cgi module."""
65-
66-
params = {}
67-
for key in field_storage.keys():
68-
try:
69-
params[key] = field_storage[key].value
70-
except AttributeError:
71-
if isinstance(field_storage[key], basestring):
72-
params[key] = field_storage[key]
73-
74-
return params
75-
7661
def exception_trace(tag, exc, log):
7762
message = traceback.format_exception(*sys.exc_info())
7863
log.error("[%s] ExcList: %s" % (tag, "".join(message),))
@@ -530,7 +515,7 @@ def identify(self, environ):
530515
return {}
531516
else:
532517
session_info = self._eval_authn_response(
533-
environ, cgi_field_storage_to_dict(post),
518+
environ, post,
534519
binding=binding)
535520
except Exception, err:
536521
environ["s2repoze.saml_error"] = err

0 commit comments

Comments
 (0)