Improve warning messages

Signed-off-by: Ivan Kanakarakis <[email protected]>

Author: c00kiemon5ter

src/saml2/client_base.py

@@ -191,8 +191,11 @@ def __init__(self, config=None, identity_cache=None, state_cache=None,
             ]
         ):
             warn_msg = (
-                "The SAML service provider accepts unsigned SAML Responses "
-                "and Assertions. This configuration is insecure."
+                "The SAML service provider accepts "
+                "unsigned SAML Responses and Assertions. "
+                "This configuration is insecure. "
+                "Consider setting want_assertions_signed, want_response_signed "
+                "or want_assertions_or_response_signed configuration options."
             )
             logger.warning(warn_msg)
             _warn(warn_msg)

src/saml2/mdstore.py

@@ -193,7 +193,7 @@ def destinations(srvs):
         "instead, use `saml2.mdstore.locations` or `saml2.mdstore.all_locations`."
     )
     logger.warning(warn_msg)
-    _warn(warn_msg)
+    _warn(warn_msg, DeprecationWarning)
     values = list(locations(srvs))
     return values
 

src/saml2/server.py

@@ -7,7 +7,6 @@
 """
 import logging
 import os
-from warnings import warn as _warn
 
 import importlib
 import dbm
@@ -525,11 +524,8 @@ def create_attribute_response(self, identity, in_response_to, destination,
 
         if not name_id and userid:
             try:
-                name_id = self.ident.construct_nameid(userid, policy,
-                                                      sp_entity_id)
-                warn_msg = "Unspecified NameID format"
-                logger.warning(warn_msg)
-                _warn(warn_msg)
+                name_id = self.ident.construct_nameid(userid, policy, sp_entity_id)
+                logger.warning("Unspecified NameID format")
             except Exception:
                 pass