Skip to content

Commit c42cb80

Browse files
committed
change "name" values in test cases to a single string, because output formatting is more difficult with lists.
reordered sp-08
1 parent 41a19d6 commit c42cb80

File tree

1 file changed

+21
-21
lines changed

1 file changed

+21
-21
lines changed

src/sp_test/tests.py

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ def pre_processing(self, message, **kwargs):
366366
OPERATIONS = {
367367
'sp-00': {
368368
"name": 'Basic Login test',
369-
"descr": 'GET startpage from SP, verify authentication request, verify ' \
369+
"descr": 'GET startpage from SP, verify authentication request, verify '
370370
'HTTP-Response after sending the SAML response',
371371
"sequence": [(Login, AuthnRequest, AuthnResponse, None)],
372372
"tests": {"pre": [], "post": []}
@@ -377,15 +377,24 @@ def pre_processing(self, message, **kwargs):
377377
"sequence": [(Login, AuthnRequest, AuthnResponse, check.VerifyEchopageContents)],
378378
"tests": {"pre": [], "post": []}
379379
},
380+
'sp-08': {
381+
"name": "SP should accept a Response without a "
382+
"SubjectConfirmationData element. If confirmation method"
383+
"is SCM_SENDER_VOUCHES",
384+
"sequence": [(Login, AuthnRequest,
385+
AuthnResponse_without_SubjectConfirmationData_2,
386+
check.ErrorResponse)],
387+
"tests": {"pre": [], "post": []}
388+
},
380389
'FL02': {
381390
"name": 'Verify various aspects of the generated AuthnRequest message',
382391
"descr": 'Basic Login test',
383392
"sequence": [],
384393
"tests": {"pre": [], "post": []}
385394
},
386395
'FL03': {
387-
"name": """SP should not accept a Response as valid, when the
388-
StatusCode is not success""",
396+
"name": "SP should not accept a Response as valid, when the StatusCode"
397+
" is not success",
389398
"sequence": [(Login, AuthnRequest, ErrorResponse, check.ErrorResponse)],
390399
"tests": {"pre": [], "post": []}
391400
},
@@ -408,41 +417,32 @@ def pre_processing(self, message, **kwargs):
408417
"tests": {"pre": [], "post": []}
409418
},
410419
'FL07': {
411-
"name": ("SP should accept a Response without a ",
412-
"SubjectConfirmationData element. If confirmation method",
413-
"is SCM_SENDER_VOUCHES"),
420+
"name": "SP should accept a Response without a "
421+
"SubjectConfirmationData element. If confirmation method "
422+
"is SCM_SENDER_VOUCHES",
414423
"sequence": [(Login, AuthnRequest,
415424
AuthnResponse_without_SubjectConfirmationData_1, None)],
416425
"tests": {"pre": [], "post": []}
417426
},
418427
'FL09': {
419-
"name": ("SP should not accept a response InResponseTo ",
420-
"which is chosen randomly"),
428+
"name": "SP should not accept a response InResponseTo "
429+
"which is chosen randomly",
421430
"sequence": [(Login, AuthnRequest,
422431
AuthnResponse_rnd_Response_inresponseto,
423432
check.ErrorResponse)],
424433
"tests": {"pre": [], "post": []}
425434
},
426435
'FL10': {
427-
"name": ("SP should not accept an assertion InResponseTo ",
428-
"which is chosen randomly"),
436+
"name": "SP should not accept an assertion InResponseTo "
437+
"which is chosen randomly",
429438
"sequence": [(Login, AuthnRequest,
430439
AuthnResponse_rnd_Response_assertion_inresponseto,
431440
check.ErrorResponse)],
432441
"tests": {"pre": [], "post": []}
433442
},
434-
'sp-08': {
435-
"name": ("SP should accept a Response without a ",
436-
"SubjectConfirmationData element. If confirmation method",
437-
"is SCM_SENDER_VOUCHES"),
438-
"sequence": [(Login, AuthnRequest,
439-
AuthnResponse_without_SubjectConfirmationData_2,
440-
check.ErrorResponse)],
441-
"tests": {"pre": [], "post": []}
442-
},
443443
'FL12': {
444-
"name": ("Do the SP allow the InResponseTo attribute to be missing",
445-
"from the SubjectConfirmationData element?"),
444+
"name": "Do the SP allow the InResponseTo attribute to be missing"
445+
"from the SubjectConfirmationData element?",
446446
"sequence": [(Login, AuthnRequest,
447447
AuthnResponse_SubjectConfirmationData_no_inresponse,
448448
check.ErrorResponse)],

0 commit comments

Comments
 (0)