Skip to content

Commit dcb6cd6

Browse files
Merge pull request #680 from tauceti2/fix_disco_url_creation
Disco URL can already contain parameters
2 parents bdaf5bf + 73d3d27 commit dcb6cd6

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/saml2/client_base.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -925,7 +925,11 @@ def create_discovery_service_request(url, entity_id, **kwargs):
925925
}
926926

927927
params = urlencode({k: v for k, v in args.items() if v})
928-
return "%s?%s" % (url, params)
928+
# url can already contain some parameters
929+
if '?' in url:
930+
return "%s&%s" % (url, params)
931+
else:
932+
return "%s?%s" % (url, params)
929933

930934
@staticmethod
931935
def parse_discovery_service_response(url="", query="",

0 commit comments

Comments
 (0)