Skip to content

Commit e08b3ff

Browse files
author
Ioannis Kakavas
committed
Allow deployers to override default True parameters
1 parent 303efd9 commit e08b3ff

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

src/saml2/client_base.py

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -108,16 +108,23 @@ def __init__(self, config=None, identity_cache=None, state_cache=None,
108108
else:
109109
self.state = state_cache
110110

111+
# Handle values which are False by default
111112
self.logout_requests_signed = False
112113
self.allow_unsolicited = False
113114
self.authn_requests_signed = False
114115
self.want_assertions_signed = False
115-
self.want_response_signed = True
116-
for foo in ["allow_unsolicited", "authn_requests_signed",
117-
"logout_requests_signed", "want_assertions_signed"]:
118-
v = self.config.getattr(foo, "sp")
116+
for param in ["allow_unsolicited", "authn_requests_signed",
117+
"logout_requests_signed", "want_assertions_signed"]:
118+
v = self.config.getattr(param, "sp")
119119
if v is True or v == 'true':
120-
setattr(self, foo, True)
120+
setattr(self, param, True)
121+
122+
# Handle values which are True by default
123+
self.want_response_signed = True
124+
for param in ["want_assertions_signed"]:
125+
v = self.config.getattr(param, "sp")
126+
if v is False or v == 'false':
127+
setattr(self, param, False)
121128

122129
self.artifact2response = {}
123130

0 commit comments

Comments
 (0)