Skip to content

Commit e3e9aea

Browse files
committed
Use raises as a context manager
Signed-off-by: Ivan Kanakarakis <[email protected]>
1 parent a76cd33 commit e3e9aea

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

tests/test_02_saml.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,15 @@ def test_loadd(self):
4343
print(ava)
4444
ee = saml2.ExtensionElement("")
4545

46-
raises(KeyError, "ee.loadd(ava)")
46+
with raises(KeyError):
47+
ee.loadd(ava)
4748

4849
ava["tag"] = "foo"
4950
del ava["namespace"]
5051

5152
ee = saml2.ExtensionElement("")
52-
raises(KeyError, "ee.loadd(ava)")
53+
with raises(KeyError):
54+
ee.loadd(ava)
5355

5456
def test_find_children(self):
5557
ava = {
@@ -211,8 +213,8 @@ def test_make_vals_str(self):
211213
def test_make_vals_multi_dict(self):
212214
ava = ["foo", "bar", "lions", "saints"]
213215

214-
raises(Exception,
215-
"saml2.make_vals(ava, AttributeValue, Attribute(), part=True)")
216+
with raises(Exception):
217+
saml2.make_vals(ava, AttributeValue, Attribute(), part=True)
216218

217219
attr = Attribute()
218220
saml2.make_vals(ava, AttributeValue, attr, prop="attribute_value")
@@ -654,7 +656,7 @@ def testUsingTestData(self):
654656
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
655657
NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:basic"
656658
Name="FirstName">
657-
<AttributeValue
659+
<AttributeValue
658660
xsi:type="xs:base64Binary">VU5JTkVUVA==</AttributeValue>
659661
</Attribute>"""
660662

0 commit comments

Comments
 (0)