Raise ValueError for invalid attribute type

Without this patch, the AttributeValueBase set_text method checks for a
valid xsi:type before setting the text value, but when it gets to the
catchall case, instead of raising an exception it simply creates an
unassigned ValueError instance and does nothing with it. This is clearly
not intentional, and it is a problem because it means it is possible to
set an invalid xsi:type for an AttributeValue. This patch corrects the
error by raising the ValueError exception rather than letting it
disappear into the ether.

Author: cmurphy

src/saml2/saml.py

@@ -224,7 +224,7 @@ def set_text(self, val, base64encode=False):
                         elif typ == "xs:base64Binary":
                             pass
                         else:
-                            ValueError("Type and value doesn't match")
+                            raise ValueError("Type and value doesn't match")
             elif isinstance(val, bool):
                 if val:
                     val = "true"

tests/test_02_saml.py

@@ -243,6 +243,10 @@ def test_set_text(self):
         av.set_text(None)
         assert av.text == ""
 
+        av = AttributeValue()
+        av.set_type('invalid')
+        raises(ValueError, "av.set_text('free text')")
+
     def test_make_vals_div(self):
         foo = saml2.make_vals(666, AttributeValue, part=True)
         assert foo.text == "666"