Skip to content

Commit c933832

Browse files
committed
fix(dockerfile-linux): move configuration data into the image
Volumes should be used only for things that a containerized application might change at runtime (e.g., `/var/lib/mysql`), not for user configuration. In particular, this `VOLUME` directive would break a derivative image's ability to modify the configuation data. Users can also mount any configuration data at runtime, making the volume unnecessary.
1 parent be881bc commit c933832

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

Dockerfile-linux.template

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,6 @@ RUN set -eux; \
121121
cp -a /tmp/satosa/example /usr/share/satosa; \
122122
rm -rf /tmp/satosa
123123

124-
VOLUME /etc/satosa
125124
WORKDIR /etc/satosa
126125

127126
COPY docker-entrypoint.sh /usr/local/bin/

0 commit comments

Comments
 (0)