From 037da303a1c942fa737d71107c795ae851d077b6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alicia=20Boya=20Garc=C3=ADa?= <aboya@igalia.com>
Date: Wed, 7 May 2025 13:17:36 +0200
Subject: [PATCH] wkdev-update: Do not pass --exit-when-done to wkdev-create

Fixes https://github.com/Igalia/webkit-container-sdk/issues/117
---
 scripts/host-only/wkdev-update | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/scripts/host-only/wkdev-update b/scripts/host-only/wkdev-update
index cb977a0..8f79508 100755
--- a/scripts/host-only/wkdev-update
+++ b/scripts/host-only/wkdev-update
@@ -100,7 +100,15 @@ update_containers_using_image() {
 
             local recreate_arguments=()
             recreate_arguments+=("--home" "$(get_podman_container_home_directory_on_host "${container_name}")")
-            recreate_arguments+=($(get_podman_container_init_arguments "${container_name}"))
+            local init_arguments=($(get_podman_container_init_arguments "${container_name}"))
+            for arg in "${init_arguments[@]}"; do
+                # wkdev-create --attach passes the --exit-when-done option to .wkdev-init so that
+                # podman start --attach doesn't hang forever.
+                # --exit-when-done is not an option of wkdev-create however, so we need to skip it.
+                if [[ "${arg}" != "--exit-when-done" ]]; then
+                    recreate_arguments+=("${arg}")
+                fi
+            done
             outdated_container_data["${container_name}"]=${recreate_arguments[@]}
         fi