[WIP] Update type hints and PHPDocs in Rules classes

Author: emsifa

src/Rules/After.php

@@ -19,10 +19,10 @@ class After extends Rule
      * Check the value is valid
      *
      * @param mixed $value
-     * @return mixed
+     * @return bool
      * @throws Exception
      */
-    public function check($value)
+    public function check($value): bool
     {
         $this->requireParameters($this->fillableParams);
         $time = $this->parameter('time');

src/Rules/Callback.php

@@ -21,7 +21,7 @@ class Callback extends Rule
      * @param Closure $callback
      * @return self
      */
-    public function setCallback(Closure $callback): self
+    public function setCallback(Closure $callback): Rule
     {
         return $this->setParameter('callback', $callback);
     }
@@ -30,10 +30,10 @@ public function setCallback(Closure $callback): self
      * Check the $value is valid
      *
      * @param mixed $value
-     * @return mixed
+     * @return bool
      * @throws Exception
      */
-    public function check($value)
+    public function check($value): bool
     {
         $this->requireParameters($this->fillableParams);
 

src/Rules/FileTrait.php

@@ -11,9 +11,9 @@ trait FileTrait
      * Check whether value is from $_FILES
      *
      * @param mixed $value
-     * @return mixed
+     * @return bool
      */
-    public function isValueFromUploadedFiles($value)
+    public function isValueFromUploadedFiles($value): bool
     {
         if (!is_array($value)) {
             return false;
@@ -43,10 +43,10 @@ public function isUploadedFile($value): bool
     /**
      * Given $size and get the bytes
      *
-     * @param mixed $size
-     * @return mixed
+     * @param string|int $size
+     * @return int
      */
-    protected function getBytes($size)
+    protected function getBytes($size): int
     {
         if (is_int($size)) {
             return $size;

src/Rules/In.php

@@ -45,7 +45,7 @@ public function strict(bool $strict = true)
      * @param mixed $value
      * @return bool
      */
-    public function check($value)
+    public function check($value): bool
     {
         $this->requireParameters(['allowed_values']);
 

src/Rules/UploadedFile.php

@@ -12,10 +12,10 @@ class UploadedFile extends Rule
     /** @var string */
     protected $message = "The :attribute is not valid";
 
-    /** @var mixed */
+    /** @var string|int */
     protected $maxSize = null;
 
-    /** @var mixed */
+    /** @var string|int */
     protected $minSize = null;
 
     /** @var array */
@@ -25,7 +25,7 @@ class UploadedFile extends Rule
      * Given $params and assign $this->params
      *
      * @param array $params
-     * @return Rule
+     * @return self
      */
     public function fillParameters(array $params): Rule
     {
@@ -39,10 +39,10 @@ public function fillParameters(array $params): Rule
     /**
      * Given $size and set the max size
      *
-     * @param mixed $size
-     * @return Rule
+     * @param string|int $size
+     * @return self
      */
-    public function maxSize($size)
+    public function maxSize($size): Rule
     {
         $this->params['max_size'] = $size;
         return $this;
@@ -51,10 +51,10 @@ public function maxSize($size)
     /**
      * Given $size and set the min size
      *
-     * @param mixed $size
-     * @return Rule
+     * @param string|int $size
+     * @return self
      */
-    public function minSize($size)
+    public function minSize($size): Rule
     {
         $this->params['min_size'] = $size;
         return $this;
@@ -63,11 +63,11 @@ public function minSize($size)
     /**
      * Given $min and $max then set the range size
      *
-     * @param mixed $min
-     * @param mixed $max
-     * @return Rule
+     * @param string|int $min
+     * @param string|int $max
+     * @return self
      */
-    public function sizeBetween($min, $max)
+    public function sizeBetween($min, $max): Rule
     {
         $this->minSize($min);
         $this->maxSize($max);
@@ -79,9 +79,9 @@ public function sizeBetween($min, $max)
      * Given $types and assign $this->params
      *
      * @param mixed $types
-     * @return Rule
+     * @return self
      */
-    public function fileTypes($types)
+    public function fileTypes($types): Rule
     {
         if (is_string($types)) {
             $types = explode('|', $types);

src/Rules/Url.php

@@ -30,7 +30,7 @@ public function fillParameters(array $params): Rule
      * @param array $schemes
      * @return self
      */
-    public function forScheme($schemes): self
+    public function forScheme($schemes): Rule
     {
         $this->params['schemes'] = (array) $schemes;
         return $this;