Regex rule - unexpected warning with comma character

Author: Tomasz Ferfecki

src/Validation.php

@@ -344,7 +344,12 @@ protected function parseRule($rule)
     {
         $exp = explode(':', $rule, 2);
         $rulename = $exp[0];
-        $params = isset($exp[1])? explode(',', $exp[1]) : [];
+        if ($rulename !== 'regex') {
+            $params = isset($exp[1])? explode(',', $exp[1]) : [];
+        } else {
+            $params = [$exp[1]];
+        }
+
         return [$rulename, $params];
     }
 

tests/ValidatonTest.php

@@ -0,0 +1,71 @@
+<?php
+
+use Rakit\Validation\Validation;
+
+class ValidatonTest extends PHPUnit_Framework_TestCase
+{
+    /**
+     * @param string $rules
+     * @param array $expectedResult
+     *
+     * @dataProvider parseRuleProvider
+     */
+    public function testParseRule($rules, $expectedResult)
+    {
+        $class = new ReflectionClass(Validation::class);
+        $method = $class->getMethod('parseRule');
+        $method->setAccessible(true);
+
+        $validationMock = $this->getMockBuilder(Validation::class)
+            ->disableOriginalConstructor()
+            ->setMethodsExcept(['parseRule'])
+            ->getMock();
+
+        $result = $method->invokeArgs($validationMock, [$rules]);
+        $this->assertSame($expectedResult, $result);
+    }
+
+    /**
+     * @return array
+     */
+    public function parseRuleProvider()
+    {
+        return [
+            [
+                'email',
+                [
+                    'email',
+                    [],
+                ],
+            ],
+            [
+                'min:6',
+                [
+                    'min',
+                    ['6'],
+                ],
+            ],
+            [
+                'uploaded_file:0,500K,png,jpeg',
+                [
+                    'uploaded_file',
+                    ['0', '500K', 'png', 'jpeg'],
+                ],
+            ],
+            [
+                'same:password',
+                [
+                    'same',
+                    ['password'],
+                ],
+            ],
+            [
+                'regex:/^([a-zA-Z\,]*)$/',
+                [
+                    'regex',
+                    ['/^([a-zA-Z\,]*)$/'],
+                ],
+            ],
+        ];
+    }
+}