Merge pull request #15 from adelowo/rules

Internal rules can now be modified

Author: emsifa

src/Validator.php

@@ -12,6 +12,8 @@ class Validator
 
     protected $validators = [];
 
+    protected $allowRuleOverride = false;
+
     public function __construct(array $messages = [])
     {
         $this->messages = $messages;
@@ -106,12 +108,17 @@ protected function registerBaseValidators()
 
     public function addValidator($ruleName, Rule $rule)
     {
-        if (array_key_exists($ruleName, $this->validators)) {
+        if (!$this->allowRuleOverride && array_key_exists($ruleName, $this->validators)) {
             throw new RuleQuashException(
                 "You cannot override a built in rule. You have to rename your rule"
             );
         }
 
         $this->setValidator($ruleName, $rule);
     }
+
+    public function allowRuleOverride($status = false)
+    {
+        $this->allowRuleOverride = $status;
+    }
 }

tests/ValidatorTest.php

@@ -347,6 +347,21 @@ public function testInternalValidationRuleCannotBeOverridden()
         $validation->validate();
     }
 
+    public function testInternalValidationRuleCanBeOverridden()
+    {
+        $this->validator->allowRuleOverride(true);
+
+        $this->validator->addValidator('required', new Required()); //This is a custom rule defined in the fixtures directory
+
+        $data = ['s' => json_encode(['name' => 'space x', 'human' => false])];
+
+        $validation = $this->validator->make($data, ['s' => 'required'], []);
+
+        $validation->validate();
+
+        $this->assertTrue($validation->passes());
+    }
+
     public function testIgnoreNextRulesWhenImplicitRulesFails()
     {
         $validation = $this->validator->validate([