fix(*): changing previous replace with the util func

Author: ChronosSF

demos/combo/load-on-demand.html

@@ -54,7 +54,7 @@
         //  Helper function to put an item data token to the selected item table utilizing a jQuery template
         var selectedItemTemplate = '<tr><td class="propName">${propertyName}</td><td class="propValue">${propertyValue}</td></tr>';
         function addItemValue(tableObject, item, itemProp) {
-            if (typeof item[itemProp] !== "function") {
+            if ($.ig.util.getType(item[itemProp]) !== "function") {
                 $($.ig.tmpl(selectedItemTemplate,
                     {
                         "propertyName": itemProp,

src/js/modules/infragistics.datasource.js

@@ -3993,7 +3993,7 @@
 			/* fire the data binding event */
 			args = { cancel: false };
 
-			if (typeof p.dataBinding === "function") {
+			if ($.ig.util.getType(p.dataBinding) === "function") {
 				noCancel = p.dataBinding(this, args);
 				if (noCancel === undefined) {
 					noCancel = true;
@@ -4256,7 +4256,7 @@
 		},
 		_internalDataBound: function (callDatabound) {
 			// M.H. 18 Aug 2014 Fix for bug #177147: The dataBound event is called before the JSON file is returned
-			if (callDatabound && typeof this.settings.dataBound === "function") {
+			if (callDatabound && $.ig.util.getType(this.settings.dataBound) === "function") {
 				this.settings.dataBound(this);
 			}
 		},
@@ -4827,7 +4827,7 @@
 				"extraParams": extraParams,
 				"pkParams": pkParams
 			};
-			if (typeof props.urlParamsEncoding === "function") {
+			if ($.ig.util.getType(props.urlParamsEncoding) === "function") {
 				//args = props.urlParamsEncoding(this, params);
 				noCancel = props.urlParamsEncoding(this, params);
 			}
@@ -4847,7 +4847,7 @@
 					this.settings.encodeExtraParams(this, params);
 				}
 
-				if (typeof props.urlParamsEncoded === "function") {
+				if ($.ig.util.getType(props.urlParamsEncoded) === "function") {
 					props.urlParamsEncoded(this, params);
 				}
 			}
@@ -5661,7 +5661,7 @@
 					direction = "";
 				}
 				/* check if a custom conversion function is set */
-				if (typeof s.customConvertFunc === "function") {
+				if ($.ig.util.getType(s.customConvertFunc) === "function") {
 					convertFunc = s.customConvertFunc;
 				}
 				/*else {
@@ -10967,7 +10967,7 @@
 					};
 				}
 				/* check if a custom conversion function is set */
-				if (typeof s.customConvertFunc === "function") {
+				if ($.ig.util.getType(s.customConvertFunc) === "function") {
 					convertFunc = s.customConvertFunc;
 				}
 				/* else {

src/js/modules/infragistics.ui.combo.js

@@ -5131,6 +5131,7 @@
 				options = this.options,
 				isStringDataSource = $.ig.util.getType(options.dataSource) === "string",
 				url = options.dataSourceUrl;
+				dataSourceType = $.ig.util.getType(options.dataSource);
 
 			// Set the data source that should be used
 			if (!options.dataSource && this.element.is("select")) {
@@ -5144,7 +5145,7 @@
 			}
 
 			// P.P. 29-June-2015 Bug #201942: We need to unwrap the data here, because of the following logic.
-			if ($.ig.util.getType(options.dataSource) === "function") {
+			if (dataSourceType === "function") {
 				options.dataSource = options.dataSource();
 			}
 
@@ -5156,8 +5157,8 @@
 				this._convertToArrayOfObjects(options);
 
 				// Analyze the schema only when the data source is array or function
-				if (!schema && options.dataSource && ($.isArray(options.dataSource) ||
-					typeof options.dataSource === "function")) {
+				if (!schema && options.dataSource && (dataSourceType === "array" ||
+					dataSourceType === "function")) {
 
 					// N.A. 5/18/2015 Bug #193129: Unwrap before extracting the schema from the first field element.
 					schema = this._initSchema(this._unwrapData(options.dataSource)[ 0 ]);
@@ -5208,7 +5209,7 @@
 				}
 
 				// S.T. Feb 24th, 2015 Bug #189447: Handle when data source is JSONP.
-				if ($.ig.util.getType(options.dataSource) === "string" &&
+				if (dataSourceType === "string" &&
 					!options.dataSourceType &&
 					$.ig.util.isJsonpUrl(options.dataSource)) {
 

src/js/modules/infragistics.ui.htmleditor.js

@@ -3158,7 +3158,7 @@
                 // and select formatting option, the text on the whole row gets updated
                 self._selectClosestTextNode();
 
-                if (typeof callback === "function") {
+                if ($.ig.util.getType(callback) === "function") {
                     callback.call(self);
                 }
         },
@@ -3349,9 +3349,9 @@
                 }
             }
 
-            if (typeof customCommand === "function" && browser === null) {
+            if ($.ig.util.getType(customCommand) === "function" && browser === null) {
                 customCommand.call(this, name, args);
-            } else if (typeof customCommand === "function" && isCommandSupported) {
+            } else if ($.ig.util.getType(customCommand) === "function" && isCommandSupported) {
                 customCommand.apply(this, customCommandArgs);
             } else {
                 this._document.execCommand(name, false, args);
@@ -3670,8 +3670,8 @@
 
             $.each(this._callbackMap, function (isTrueFunc, callback) {
                 var isTrueRes = self[ isTrueFunc ](el);
-                if (typeof self[ isTrueFunc ] === "function" && isTrueRes &&
-                    typeof self[ callback ] === "function") {
+                if ($.ig.util.getType(self[ isTrueFunc ]) === "function" && isTrueRes &&
+                    $.ig.util.getType(self[ callback ]) === "function") {
                     self[ callback ](el, isTrueRes);
 
                     // Bug #184142 In IE justify left button is not active by default

src/js/modules/infragistics.ui.toolbar.js

@@ -80,7 +80,7 @@
             return this.settings.localeProperties;
         },
         callbackRenderer: function () {
-            if (this.settings.callbackRenderer && typeof this.settings.callbackRenderer === "function") {
+            if (this.settings.callbackRenderer && $.ig.util.getType(this.settings.callbackRenderer) === "function") {
                 return this.settings.callbackRenderer();
             }
         },
@@ -945,7 +945,7 @@
                 },
                 tbItemsPropsTraversing = function (key, property) {
                     var scope = o.items[ i ].scope || self;
-                    if (property.action !== undefined && typeof scope[ property.action ] === "function") {
+                    if (property.action !== undefined && $.ig.util.getType(scope[ property.action ]) === "function") {
                         scope[ property.action ](newItem, property, itemProps);
                         return;
                     }

src/js/modules/infragistics.util.jquery.js

@@ -1221,7 +1221,7 @@
 		var beforeSend = function (jqXHR, options) {
 			if (requestOptions) {
 
-				if (typeof requestOptions.beforeSend === "function") {
+				if ($.ig.util.getType(requestOptions.beforeSend) === "function") {
 					jqXHR.setRequestHeader("Content-Type", contentType);
 					requestOptions.beforeSend.call(this, jqXHR, options, requestOptions);
 				}

tests/unit/htmleditor/basicfunctionalities/rendering/htmleditor-test.js

@@ -183,7 +183,7 @@ QUnit.module("igHTMLEditor unit tests", {
 	buttonCombinationsTest: function () {
 		var i, buttonsNames = arguments;
 		for (i = 0; i < buttonsNames.length; i++) {
-			if (typeof this[buttonsNames[i]] === "function") {
+			if ($.ig.util.getType(this[buttonsNames[i]]) === "function") {
 				this[buttonsNames[i]]();
 			}
 		}
@@ -355,7 +355,7 @@ QUnit.module("igHTMLEditor unit tests", {
 			self.htmlEditor.igHtmlEditor('executeAction', actionName, param);
 
 			var condition = false;
-			if (typeof conditionCallBack === "function") {
+			if ($.ig.util.getType(conditionCallBack) === "function") {
 				condition = conditionCallBack.call(p, self.editorBody);
 			}
 			self.assert.ok(condition, 'Execute action ' + actionName + " combo.");
@@ -383,7 +383,7 @@ QUnit.module("igHTMLEditor unit tests", {
 			self.htmlEditor.data("igHtmlEditor")._selectionWrapperSaved.select(p.contents());
 			button.trigger("click");
 			var condition = false;
-			if (typeof conditionCallBack === "function") {
+			if ($.ig.util.getType(conditionCallBack) === "function") {
 				condition = conditionCallBack.call(p, self.editorBody);
 			}
 			self.assert.ok(condition, buttonName + " combo.");
@@ -415,7 +415,7 @@ QUnit.module("igHTMLEditor unit tests", {
 			return $.ig.TestUtil.wait(200);
 		}).then(function () {
 			var condition = false;
-			if (typeof conditionCallBack === "function") {
+			if ($.ig.util.getType(conditionCallBack) === "function") {
 				condition = conditionCallBack.call(p, self.editorBody);
 			}
 			combo.igCombo("closeDropDown");