fix(*): more deprecated API usage fixes

ChronosSF · ChronosSF · commit 6b10ac0b15af · 2025-02-12T17:39:37.000+02:00
diff --git a/src/js/modules/infragistics.ui.combo.js b/src/js/modules/infragistics.ui.combo.js
@@ -4976,8 +4976,8 @@
 				this._options.$input.attr("disabled", true);
 				this._options.$hiddenInput.attr("disabled", true);
 			} else {
-				this._options.$input.removeAttr("disabled");
-				this._options.$hiddenInput.removeAttr("disabled");
+				this._options.$input.remoteProp("disabled");
+				this._options.$hiddenInput.removeProp("disabled");
 			}
 		},
 		changeLocale: function () {
diff --git a/src/js/modules/infragistics.ui.dialog.js b/src/js/modules/infragistics.ui.dialog.js
@@ -1170,7 +1170,7 @@
 			this.element.stop(true, true);
 			this._doClose(null, true);
 			if (self._winResize) {
-				$(window).unbind("resize", self._winResize);
+				$(window).off("resize", self._winResize);
 			}
 			this.element.children(".ui-igdialog-header").remove();
 			this.element.children(".ui-igdialog-footer").remove();
@@ -1186,7 +1186,7 @@
 			if (this.options.resizable) {
 				this.element.resizable("destroy");
 			}
-			this.element.unbind();
+			this.element.off();
 
 			// if (next && next.parentNode === dad) {
 				// dad.insertBefore(elem0, next);
@@ -1951,7 +1951,7 @@
 			}
 			if (remove) {
 				if (self._focBind) {
-					self._focBind.unbind(focusEvt);
+					self._focBind.off(focusEvt);
 					delete self._focBind;
 				}
 				return;
diff --git a/src/js/modules/infragistics.ui.editors.js b/src/js/modules/infragistics.ui.editors.js
@@ -572,7 +572,7 @@
 				}
 			}
 			if (disabled) {
-				element.removeAttr("disabled");
+				element.removeProp("disabled");
 
 				// If we have 'disabled' attribute, then it is applied only when 'disabled' options is not defined.
 				if (this._definedOptions === undefined || this._definedOptions.disabled === undefined) {
@@ -2240,7 +2240,7 @@
 		_enableSpinButton: function (target, type) {
 			if (target && target.attr("disabled")) {
 				target.removeClass(this.css.disabled);
-				target.removeAttr("disabled");
+				target.removeProp("disabled");
 				target.prop("disabled", false);
 				this._attachButtonsEvents(type, target);
 			}
diff --git a/src/js/modules/infragistics.ui.htmleditor.js b/src/js/modules/infragistics.ui.htmleditor.js
@@ -2331,7 +2331,7 @@
             ```
             */
             this._superApply(arguments);
-            $(this.workspace.contentWindow).undelegate();
+            $(this.workspace.contentWindow).off();
             this._destroyPopovers();
             this._viewSourceBtn.igButton("destroy");
             this.element.removeClass(this.css.htmlEditor)
diff --git a/src/js/modules/infragistics.ui.popover.js b/src/js/modules/infragistics.ui.popover.js
@@ -865,17 +865,17 @@
 				(typeof t[ 0 ] === "object") && (t[ 0 ].nodeType === 1) &&
 				( typeof t[ 0 ].style === "object" ) &&
 				( typeof t[ 0 ].ownerDocument === "object" ) ) ) {
-				$(t).unbind(showEvt).on(showEvt, targetShowEvt);
-				$(t).unbind(hideEvt).on(hideEvt, targetHideEvt);
+				$(t).off(showEvt).on(showEvt, targetShowEvt);
+				$(t).off(hideEvt).on(hideEvt, targetHideEvt);
 			} else if (this.options.selectors && showEvt) {
 				this.element.find(this.options.selectors).addBack().each(function () {
 					var target = $(this)[ 0 ];
 					/* verify that no popover should be shown for the original div */
 					if (target === self.element[ 0 ]) {
 						return;
 					}
-					$(target).unbind(showEvt).on(showEvt, targetShowEvt);
-					$(target).unbind(hideEvt).on(hideEvt, targetHideEvt);
+					$(target).off(showEvt).on(showEvt, targetShowEvt);
+					$(target).off(hideEvt).on(hideEvt, targetHideEvt);
 				});
 			}
 		},
@@ -892,11 +892,11 @@
 				(typeof t[ 0 ] === "object") && (t[ 0 ].nodeType === 1) &&
 				( typeof t[ 0 ].style === "object" ) &&
 				( typeof t[ 0 ].ownerDocument === "object" ) ) ) {
-				$(t).unbind(".popover");
+				$(t).off(".popover");
 			} else if (this.options.selectors) {
 				this.element.find(this.options.selectors).addBack().each(function () {
 					var target = $(this);
-					$(target).unbind(".popover");
+					$(target).off(".popover");
 				});
 			}
 		},
diff --git a/src/js/modules/infragistics.ui.rating.js b/src/js/modules/infragistics.ui.rating.js
@@ -1112,7 +1112,7 @@
 			}
 			this.validator(1);
 			if (this._foc) {
-				this._foc.unbind().remove();
+				this._foc.off().remove();
 			}
 			this._elem.remove();
 			if (o.theme) {
diff --git a/src/js/modules/infragistics.ui.shared.js b/src/js/modules/infragistics.ui.shared.js
@@ -421,7 +421,7 @@
 					" ui-igslider-vertical" +
 					" ui-igslider-disabled")
 				.removeData("slider")
-				.unbind(".slider");
+				.off(".slider");
 
 			this._mouseDestroy();
 
@@ -531,7 +531,7 @@
 
 			// A.Y. June 6, 2011 Bug# 73864 - _mouseStart is fired so we can unbind our mauseUp handler
 			// as we know now that _mouseStop will be fired
-			$(document).unbind("mouseup." + this.widgetName, this._mouseUpHandler);
+			$(document).off("mouseup." + this.widgetName, this._mouseUpHandler);
 
 			return this._start(event, this._handleIndex);
 		},
@@ -720,7 +720,7 @@
 					this.handles.attr("disabled", "disabled");
 					this.element.addClass("ui-disabled");
 				} else {
-					this.handles.removeAttr("disabled");
+					this.handles.removeProp("disabled");
 					this.element.removeClass("ui-disabled");
 				}
 				break;
@@ -884,7 +884,7 @@
 					" ui-widget-content" +
 					" ui-corner-all")
 				.removeData("igProgressBar")
-				.unbind(".igProgressBar");
+				.off(".igProgressBar");
 			$("#" + this._id("_progress")).remove();
 			return this;
 		},
@@ -1192,7 +1192,7 @@
             if (e.hasClass(o.css.buttonDisabledClass)) {
                 e.removeClass(o.css.buttonDisabledClass);
             }
-            e.removeAttr("disabled");
+            e.removeProp("disabled");
             if (e.is("a") === true) {
                 self._setLinkOptions(true);
             }
@@ -1381,7 +1381,7 @@
 
         _dettachEvents: function () {
             this._attached = false;
-            this.element.unbind(this._events);
+            this.element.off(this._events);
         },
 
         /* Event Functions */
diff --git a/src/js/modules/infragistics.ui.splitter.js b/src/js/modules/infragistics.ui.splitter.js
@@ -858,19 +858,19 @@
                     // D.P. If _create threw this._splitter is not assigned
                     return;
                 }
-                $(this._splitter.bar).unbind(this._getEvent("focus"),
+                $(this._splitter.bar).off(this._getEvent("focus"),
                     this._getEvent("blur"),
                     this._getEvent("keydown"));
-                $(this._splitter.bar.children()[ 0 ]).unbind(this._getEvent("mousedown"));
-                $(this._splitter.bar.children()[ 1 ]).unbind(this._getEvent("mousedown"));
+                $(this._splitter.bar.children()[ 0 ]).off(this._getEvent("mousedown"));
+                $(this._splitter.bar.children()[ 1 ]).off(this._getEvent("mousedown"));
 
                 //T.P. Bug #155452 fix _removeEventHandlers so when under mobile devices mouseenter and mouseleave are not unbinded
                 if (!this._isTouch()) {
-                    $(this._splitter.bar).unbind(this._getEvent("mouseenter"),
+                    $(this._splitter.bar).off(this._getEvent("mouseenter"),
                         this._getEvent("mouseleave"));
-                    $(this._splitter.bar.children()[ 0 ]).unbind(this._getEvent("mouseenter"),
+                    $(this._splitter.bar.children()[ 0 ]).off(this._getEvent("mouseenter"),
                         this._getEvent("mouseleave"));
-                    $(this._splitter.bar.children()[ 1 ]).unbind(this._getEvent("mouseenter"),
+                    $(this._splitter.bar.children()[ 1 ]).off(this._getEvent("mouseenter"),
                         this._getEvent("mouseleave"));
                 }
             },
@@ -2299,9 +2299,9 @@
 
                 // D.A. 24th October 2013 Remove the attached events to window and document
                 if (evtHandlers) {
-                    $(document).unbind(this._getEvent("mouseup"), evtHandlers.documentMouseUp);
-                    $(document).unbind(this._getEvent("mousemove"), evtHandlers.documentMouseMove);
-                    $(window).unbind("resize", evtHandlers.windowResize);
+                    $(document).off(this._getEvent("mouseup"), evtHandlers.documentMouseUp);
+                    $(document).off(this._getEvent("mousemove"), evtHandlers.documentMouseMove);
+                    $(window).off("resize", evtHandlers.windowResize);
                 }
                 this._superApply(arguments);
                 this._opt = null;
diff --git a/src/js/modules/infragistics.ui.toolbar.js b/src/js/modules/infragistics.ui.toolbar.js
@@ -1360,9 +1360,7 @@
             */
 
             // D.U. #177516 12th of August [ igToolbar ] Method destroy remover the toolbar container
-            this.element
-                .undelegate()
-                .unbind();
+            this.element.off();
 
             this.collapseBtn
                 .igToolbarButton("destroy")
diff --git a/src/js/modules/infragistics.ui.tree.js b/src/js/modules/infragistics.ui.tree.js
@@ -4851,7 +4851,7 @@
 			this._superApply(arguments);
 
 			// K.D. February 17th, 2014 Bug #164398 Attaching events only on create as delegate is used instead of bind now.
-			this.element.undelegate();
+			this.element.off();
 			this.element.removeClass(this.css.tree);
 			this.element.removeClass(this.css.treeCollection);
 			this.element.removeClass(this.css.treeRoot);
diff --git a/src/js/modules/infragistics.ui.upload.js b/src/js/modules/infragistics.ui.upload.js
@@ -278,7 +278,7 @@
 			if (isToAttach) {
 				$(document).on(this.mouseMoveEvent);
 			} else {
-				$(document).unbind(this.mouseMoveEvent);
+				$(document).off(this.mouseMoveEvent);
 			}
 		},
 		_setOption: function (key, value) {
@@ -303,7 +303,7 @@
 
 			if (isDisabled === false) {
 				this.isVisibleFilePicker = false;
-				/* filePicker.removeAttr("disabled"); */
+				/* filePicker.removeProp("disabled"); */
 				this._attachMouseMove(true);
 				/* IE9 fix - unbind mouse over event */
 				this.element.on(this._internalEvents).mouseover();
@@ -314,15 +314,15 @@
 					width: "1px",
 					height: "1px"
 				});
-				this.element.unbind(this._internalEvents);
+				this.element.off(this._internalEvents);
 			}
 		},
 		destroy: function () {
 			/*
 				$(".selector").igUpload("destroy");
 			*/
-			this.element.unbind(this._internalEvents);
-			this.element.unbind(this.mouseMoveEvent);
+			this.element.off(this._internalEvents);
+			this.element.off(this.mouseMoveEvent);
 			this._superApply(arguments);
 			/* M.H. 10 May 2011 - fix bug 75039: remove unnecessary comment and unnecessary line of code */
 			$.ui.igButton.prototype.destroy.apply(this);
diff --git a/src/js/modules/infragistics.ui.validator.js b/src/js/modules/infragistics.ui.validator.js
@@ -1044,7 +1044,7 @@ $.widget("ui.igValidator",  $.ui.igWidget, {
 			case "onchange":
 			case "onblur":
 				if (!this.options.fields && !this.options._control) { // TODO: ignore?
-					this.element.unbind(".validator");
+					this.element.off(".validator");
 					this._attachFieldEvents(this.element);
 				}
 				break;
@@ -1253,7 +1253,7 @@ $.widget("ui.igValidator",  $.ui.igWidget, {
 	_ensureNotifier: function (options, reinit) {
 		/* Checks for and/or initializes igNotifier */
 		if (reinit && options.notifyTarget.data("igNotifier")) {
-			options.notifyTarget.igNotifier("destroy").unbind(".validator");
+			options.notifyTarget.igNotifier("destroy").off(".validator");
 		}
 		if (!options.notifyTarget.data("igNotifier")) {
 			var args = {
@@ -1382,7 +1382,7 @@ $.widget("ui.igValidator",  $.ui.igWidget, {
 			this._form._igValidators.splice(index, 1);
 			if (!this._form._igValidators.length) {
 				//also detach handler if all validators are destroyed
-				$(this._form).unbind("submit.validator");
+				$(this._form).off("submit.validator");
 			}
 		}
 	},
@@ -1765,9 +1765,9 @@ $.widget("ui.igValidator",  $.ui.igWidget, {
 	},
 	_cleanupField: function (options) {
 		var element = this._targetFromOptions(options || this.options);
-		element.unbind(".validator");
+		element.off(".validator");
 		if (options.notifyTarget && options.notifyTarget.data("igNotifier")) {
-			options.notifyTarget.igNotifier("destroy").unbind(".validator");
+			options.notifyTarget.igNotifier("destroy").off(".validator");
 		}
 		this._clearMessageTarget(options);
 		if (element.data("igValidatorField")) {
diff --git a/src/js/modules/infragistics.ui.videoplayer.js b/src/js/modules/infragistics.ui.videoplayer.js
@@ -5390,10 +5390,10 @@
 			if (this._oldHeight) {
 				this.element.css("height", this._oldHeight);
 			}
-			this.container.unbind(this._generalEvts);
-			$(document).unbind(this._documentEvts);
+			this.container.off(this._generalEvts);
+			$(document).off(this._documentEvts);
 			if (this._controlsEvts) {
-				this.container.unbind(this._controlsEvts);
+				this.container.off(this._controlsEvts);
 			}
 			this.container.removeClass(css.baseClasses);
 
@@ -5422,7 +5422,7 @@
 
 			// Will recursively call, unbind(), removeData() and remove() on all children!
 			if (this.element.is("video")) {
-				this.element.unbind(this._videoEvents);
+				this.element.off(this._videoEvents);
 				this.element.removeClass(css.videoClass);
 				this._restoreExistingVideoProperties(this.element);
 				$(":not(video)", this.container).remove();
@@ -5440,7 +5440,7 @@
 		},
 		_destroyBookmarks: function () {
 			if (this.bookmarkElements && this.bookmarkElements.length > 0) {
-				this.bookmarkElements.unbind();
+				this.bookmarkElements.off();
 				this.bookmarkElements.removeData();
 				delete this.bookmarkElements;
 				$("#" + this._id("_bookmarks")).remove();
diff --git a/src/js/modules/infragistics.ui.zoombar.js b/src/js/modules/infragistics.ui.zoombar.js
@@ -898,7 +898,7 @@
 			}
 			if (this._dragEnd(evt)) {
 				target.removeClass(this.css.windowGrabbingClass);
-				$(evt.currentTarget).unbind({
+				$(evt.currentTarget).off({
 					"mousemove.zoombar": this._zoombarMouseMoveHandler,
 					"pointermove.zoombar": this._zoombarMouseMoveHandler,
 					"MSPointerMove.zoombar": this._zoombarMouseMoveHandler
@@ -1386,29 +1386,29 @@
 				te = {}, pe = {}, me = {}, we = {};
 			te[ "touchstart." + this.id() ] = this._zoombarTouchStartHandler;
 			te[ "touchend." + this.id() ] = this._zoombarTouchEndHandler;
-			wnd.unbind(te);
+			wnd.off(te);
 			this.container()[ 0 ].removeEventListener("touchmove", this._zoombarTouchMoveHandler);
 			if (window.navigator.pointerEnabled) {
 				pe[ "pointerdown." + this.id() ] = this._zoombarMouseDownHandler;
 				pe[ "pointerup." + this.id() ] = this._zoombarMouseUpHandler;
-				wnd.unbind(pe);
+				wnd.off(pe);
 			} else if (window.navigator.msPointerEnabled) {
 				pe[ "MSPointerDown." + this.id() ] = this._zoombarMouseDownHandler;
 				pe[ "MSPointerUp." + this.id() ] = this._zoombarMouseUpHandler;
-				wnd.unbind(pe);
+				wnd.off(pe);
 			} else {
 				me[ "mousedown." + this.id() ] = this._zoombarMouseDownHandler;
 				me[ "mouseup." + this.id() ] = this._zoombarMouseUpHandler;
-				wnd.unbind(me);
+				wnd.off(me);
 			}
 			we[ "mousewheel." + this.id() ] = this._zoombarMouseWheelHandler;
 			we[ "DOMMouseScroll." + this.id() ] = this._zoombarMouseWheelHandler;
-			wnd.unbind(we);
-			this._sbt.unbind({
+			wnd.off(we);
+			this._sbt.off({
 				"mouseenter.zoombar": this._scrollbarThumbMouseEnterHandler,
 				"mouseleave.zoombar": this._scrollbarThumbMouseLeaveHandler
 			});
-			zwe.unbind({
+			zwe.off({
 				"keydown": this._windowKeyDownHandler,
 				"keyup": this._windowKeyUpHandler
 			});
diff --git a/tests/unit/popover/common/common-test.js b/tests/unit/popover/common/common-test.js
@@ -465,7 +465,7 @@ QUnit.test(testId_32, function (assert) {
 	this.testUtil.wait(1000).then(function () {
 		done();
 		assert.ok($('#img1_popover').css("display") === "none", "Showing cancel failed");
-		$("#img1").unbind("igpopovershowing");
+		$("#img1").off("igpopovershowing");
 	}).catch(function (er) {
 		assert.pushResult({ result: false, message: er.message });
 		done();
@@ -564,7 +564,7 @@ QUnit.test(testId_34, function (assert) {
 		$(target).trigger(event);
 		self.testUtil.wait(1000).then(function () {
 			assert.ok($('#img1_popover').css("display") !== "none", "Cancel hiding failed!");
-			$("#img1").unbind("igpopoverhiding");
+			$("#img1").off("igpopoverhiding");
 			done();
 		});
 	}).catch(function (er) {
diff --git a/tests/unit/splitter/jquery.simulate.js b/tests/unit/splitter/jquery.simulate.js
diff --git a/tests/unit/upload/upload-test.js b/tests/unit/upload/upload-test.js

Original file line number	Diff line number	Diff line change
`@@ -1170,7 +1170,7 @@`
`1170`	`1170`	`this.element.stop(true, true);`
`1171`	`1171`	`this._doClose(null, true);`
`1172`	`1172`	`if (self._winResize) {`
`1173`		`- $(window).unbind("resize", self._winResize);`
	`1173`	`+ $(window).off("resize", self._winResize);`
`1174`	`1174`	`}`
`1175`	`1175`	`this.element.children(".ui-igdialog-header").remove();`
`1176`	`1176`	`this.element.children(".ui-igdialog-footer").remove();`
`@@ -1186,7 +1186,7 @@`
`1186`	`1186`	`if (this.options.resizable) {`
`1187`	`1187`	`this.element.resizable("destroy");`
`1188`	`1188`	`}`
`1189`		`- this.element.unbind();`
	`1189`	`+ this.element.off();`
`1190`	`1190`
`1191`	`1191`	`// if (next && next.parentNode === dad) {`
`1192`	`1192`	`// dad.insertBefore(elem0, next);`
`@@ -1951,7 +1951,7 @@`
`1951`	`1951`	`}`
`1952`	`1952`	`if (remove) {`
`1953`	`1953`	`if (self._focBind) {`
`1954`		`- self._focBind.unbind(focusEvt);`
	`1954`	`+ self._focBind.off(focusEvt);`
`1955`	`1955`	`delete self._focBind;`
`1956`	`1956`	`}`
`1957`	`1957`	`return;`
Original file line number	Diff line number	Diff line change
`@@ -572,7 +572,7 @@`
`572`	`572`	`}`
`573`	`573`	`}`
`574`	`574`	`if (disabled) {`
`575`		`- element.removeAttr("disabled");`
	`575`	`+ element.removeProp("disabled");`
`576`	`576`
`577`	`577`	`// If we have 'disabled' attribute, then it is applied only when 'disabled' options is not defined.`
`578`	`578`	`if (this._definedOptions === undefined \|\| this._definedOptions.disabled === undefined) {`
`@@ -2240,7 +2240,7 @@`
`2240`	`2240`	`_enableSpinButton: function (target, type) {`
`2241`	`2241`	`if (target && target.attr("disabled")) {`
`2242`	`2242`	`target.removeClass(this.css.disabled);`
`2243`		`- target.removeAttr("disabled");`
	`2243`	`+ target.removeProp("disabled");`
`2244`	`2244`	`target.prop("disabled", false);`
`2245`	`2245`	`this._attachButtonsEvents(type, target);`
`2246`	`2246`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1112,7 +1112,7 @@`
`1112`	`1112`	`}`
`1113`	`1113`	`this.validator(1);`
`1114`	`1114`	`if (this._foc) {`
`1115`		`- this._foc.unbind().remove();`
	`1115`	`+ this._foc.off().remove();`
`1116`	`1116`	`}`
`1117`	`1117`	`this._elem.remove();`
`1118`	`1118`	`if (o.theme) {`